Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/otc 1075: property for users #178

Merged
merged 2 commits into from
May 29, 2023
Merged

Feature/otc 1075: property for users #178

merged 2 commits into from
May 29, 2023

Conversation

lruzicki
Copy link
Contributor

Ticket:
https://openimis.atlassian.net/browse/OTC-1075

Changes:

  • added property for user and i_user to check if they are imis administrator. Placed it in core module because it may be used in other places too

@lruzicki lruzicki requested a review from a user May 19, 2023 10:12
@sonarcloud
Copy link

sonarcloud bot commented May 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lruzicki lruzicki mentioned this pull request May 19, 2023
Merged
sniedzielski
sniedzielski reviewed May 26, 2023
View reviewed changes
Copy link
Contributor

@sniedzielski sniedzielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this stage I left two comments, please refer to them @lruzicki

core/models.py Show resolved Hide resolved
core/models.py Show resolved Hide resolved
@lruzicki lruzicki changed the title Feature/otc 1075 Feature/otc 1075: property for users May 29, 2023
@dborowiecki dborowiecki merged commit b84f66e into develop May 29, 2023
@dborowiecki dborowiecki deleted the feature/OTC-1075 branch May 29, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sniedzielski sniedzielski sniedzielski left review comments

@dborowiecki dborowiecki dborowiecki approved these changes

@malinowskikam malinowskikam Awaiting requested review from malinowskikam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lruzicki @dborowiecki @sniedzielski