Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OMT-323 - Registers status report #207

Merged
merged 31 commits into from
Aug 9, 2023
Merged

OMT-323 - Registers status report #207

merged 31 commits into from
Aug 9, 2023

Conversation

tdethier
Copy link
Member

@tdethier tdethier commented Aug 7, 2023

xgill and others added 30 commits June 25, 2020 07:09
…ions

Hotfix/omt 225 enable claim extensions
Fix field used to get db User
Merge pull request #80 from openimis/user
This is not exactly OMT-281 but being unable to connect with a claim administrator prevents the test at all.
As pointed out in the comment, by default, the rest framework will look for core.user_view permission among the numeric permissions of openIMIS and obviously deny access. Explicitly setting the permission on that specific view allows any authenticated user to view their own data, as intended. Unauthenticated users will still get a 403 response.
Cannot connect with non-admin user OMT-281
…orical data

MS SQL Server is super slow and does not use correctly the indexes when using a filter with a date
The interactive user has a health facility without foreign key but the claim admin has a foreign key. This method encapsulates this and is needed for OMT-281 so that price lists are available.
The cached_property would fail when called with HFID==0 (as happens in tblUsers that has no foreign key on this one)
# Conflicts:
#	core/models.py
#	core/schema.py
#	core/utils.py
Release/2022 04
MERGING RELEASE branches
Need to be merged as an hotfix to solve the policy issue on main release
@tdethier tdethier requested a review from edarchis August 7, 2023 16:05
@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tdethier tdethier marked this pull request as ready for review August 8, 2023 15:02
@delcroip delcroip merged commit 26c2acf into develop Aug 9, 2023
5 checks passed
@delcroip delcroip deleted the feature/OMT-323 branch August 9, 2023 07:14
tdethier added a commit that referenced this pull request Dec 18, 2023
* v1.2.1

* Missing __init__ in gql folder for setup

* v1.3.0

* Cannot connect with non-admin user OMT-281

This is not exactly OMT-281 but being unable to connect with a claim administrator prevents the test at all.
As pointed out in the comment, by default, the rest framework will look for core.user_view permission among the numeric permissions of openIMIS and obviously deny access. Explicitly setting the permission on that specific view allows any authenticated user to view their own data, as intended. Unauthenticated users will still get a 403 response.

* fix(Performance): Use legacy_id instead of validity_to to filter historical data
MS SQL Server is super slow and does not use correctly the indexes when using a filter with a date

* feat(Sentry): Better logging of errors in mutations

* hotfix(User): Keep user roles history

* Facilitate access to health facility

The interactive user has a health facility without foreign key but the claim admin has a foreign key. This method encapsulates this and is needed for OMT-281 so that price lists are available.

* v1.3.1

* OMT-281 follow-up when HFID is 0

The cached_property would fail when called with HFID==0 (as happens in tblUsers that has no foreign key on this one)

* v.1.3.3

* Add Migration on JSONExt column already fixed on this PR : #186
Need to be merged as an hotfix to solve the policy issue on main release

* Hotfix is_imis_admin missing from release

* OMT-323 - Registers status report

---------

Co-authored-by: xgill <38523490+xgill@users.noreply.github.com>
Co-authored-by: Eric Darchis <edarchis@bluesquarehub.com>
Co-authored-by: Eric Darchis <darchis@pobox.com>
Co-authored-by: Patrick Delcroix <patrick.delcroix@swisstph.ch>
Co-authored-by: Dragos DOBRE <dragos.dobre@swisstph.ch>
Co-authored-by: Quentin Gérôme <geromequentin@gmail.com>
Co-authored-by: Hiren Soni <65155846+hirensoni913@users.noreply.github.com>
Co-authored-by: Maxime NGOE <maxime.ngoe@gmail.com>
Co-authored-by: Kamil Malinowski <kmalinowski@soldevelo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants