Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #1265

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Update README.md #1265

merged 1 commit into from
Oct 23, 2023

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Oct 23, 2023


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@cubxxw cubxxw requested a review from Bloomingg October 23, 2023 02:29
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2023
@cubxxw cubxxw temporarily deployed to openim October 23, 2023 02:29 — with GitHub Actions Inactive
@cubxxw cubxxw temporarily deployed to openim October 23, 2023 02:29 — with GitHub Actions Inactive
@cubxxw cubxxw temporarily deployed to openim October 23, 2023 02:29 — with GitHub Actions Inactive
@cubxxw cubxxw temporarily deployed to openim October 23, 2023 02:29 — with GitHub Actions Inactive
@cubxxw cubxxw temporarily deployed to openim October 23, 2023 02:29 — with GitHub Actions Inactive
@cubxxw cubxxw temporarily deployed to openim October 23, 2023 02:29 — with GitHub Actions Inactive
@openimbot openimbot added this pull request to the merge queue Oct 23, 2023
@sweep-ai
Copy link
Contributor

sweep-ai bot commented Oct 23, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

Merged via the queue into main with commit 088b143 Oct 23, 2023
17 checks passed
@openimbot openimbot deleted the cubxxw-patch-1 branch October 23, 2023 02:30
@github-actions github-actions bot added this to the v3.1 milestone Oct 23, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@openimbot openimbot openimbot approved these changes

@kubbot kubbot kubbot approved these changes

@skiffer-git skiffer-git Awaiting requested review from skiffer-git skiffer-git is a code owner

@FGadvancer FGadvancer Awaiting requested review from FGadvancer FGadvancer is a code owner

@Bloomingg Bloomingg Awaiting requested review from Bloomingg Bloomingg was automatically assigned from openimsdk/openim-all

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@cubxxw @kubbot @openimbot