Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zk add close to avoid zk block. #1284

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

FGadvancer
Copy link
Member


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 26, 2023
@sweep-ai
Copy link
Contributor

sweep-ai bot commented Oct 26, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@FGadvancer FGadvancer temporarily deployed to openim October 26, 2023 03:12 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim October 26, 2023 03:12 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim October 26, 2023 03:12 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim October 26, 2023 03:15 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim October 26, 2023 03:15 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim October 26, 2023 03:15 — with GitHub Actions Inactive
skiffer-git
skiffer-git previously approved these changes Oct 26, 2023
withchao
withchao previously approved these changes Oct 26, 2023
@FGadvancer FGadvancer temporarily deployed to openim October 26, 2023 03:51 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim October 26, 2023 03:51 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim October 26, 2023 03:51 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim October 26, 2023 03:51 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim October 26, 2023 03:51 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim October 26, 2023 03:51 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim October 26, 2023 03:54 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim October 26, 2023 03:54 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim October 26, 2023 03:54 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim October 26, 2023 03:54 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim October 26, 2023 03:54 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim October 26, 2023 03:54 — with GitHub Actions Inactive
@cubxxw cubxxw enabled auto-merge October 26, 2023 04:04
@cubxxw cubxxw added this pull request to the merge queue Oct 26, 2023
Merged via the queue into openimsdk:main with commit 38ab3e0 Oct 26, 2023
16 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Oct 26, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Oct 26, 2023
@FGadvancer FGadvancer deleted the bug/fix_zk_block branch October 26, 2023 04:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants