Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NotNotifyUser receive offline push #1287

Merged
merged 2 commits into from
Oct 29, 2023
Merged

Conversation

a3d21
Copy link
Contributor

@a3d21 a3d21 commented Oct 26, 2023

I have read the CLA Document and I hereby sign the CLA

@a3d21 a3d21 requested review from skiffer-git, FGadvancer and a team as code owners October 26, 2023 09:19
@a3d21 a3d21 requested a review from Bloomingg October 26, 2023 09:19
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 26, 2023
@kubbot
Copy link
Contributor

kubbot commented Oct 26, 2023

CLA Assistant Lite bot: 💕 Thank you for your contribution and please kindly read and sign our 🎯https://github.com/openim-sigs/cla/blob/main/README.md.
If you wish to sign the CRA, Please copy and comment on the following sentence:


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@a3d21 a3d21 temporarily deployed to openim October 26, 2023 09:19 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim October 26, 2023 09:19 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim October 26, 2023 09:19 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim October 26, 2023 09:19 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim October 26, 2023 09:19 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim October 26, 2023 09:19 — with GitHub Actions Inactive
@sweep-ai
Copy link
Contributor

sweep-ai bot commented Oct 26, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@a3d21 a3d21 temporarily deployed to openim October 26, 2023 12:06 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim October 26, 2023 12:06 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim October 26, 2023 12:06 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim October 26, 2023 12:06 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim October 26, 2023 12:06 — with GitHub Actions Inactive
@a3d21 a3d21 temporarily deployed to openim October 26, 2023 12:06 — with GitHub Actions Inactive
@cubxxw cubxxw enabled auto-merge October 26, 2023 17:39
@cubxxw cubxxw added this pull request to the merge queue Oct 29, 2023
Merged via the queue into openimsdk:main with commit 726f14f Oct 29, 2023
15 of 16 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Oct 29, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants