Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: scheduled task splitting #1299

Merged
merged 6 commits into from
Nov 2, 2023
Merged

refactor: scheduled task splitting #1299

merged 6 commits into from
Nov 2, 2023

Conversation

withchao
Copy link
Contributor


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1298

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 30, 2023
@withchao withchao temporarily deployed to openim October 30, 2023 09:50 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 30, 2023 09:50 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 30, 2023 09:50 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 30, 2023 09:50 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 30, 2023 09:50 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 30, 2023 09:50 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 30, 2023 09:50 — with GitHub Actions Inactive
@sweep-ai
Copy link
Contributor

sweep-ai bot commented Oct 30, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #1299 (940a592) into main (d2f0af1) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1299      +/-   ##
========================================
- Coverage   2.44%   2.41%   -0.03%     
========================================
  Files         13      13              
  Lines        778     786       +8     
========================================
  Hits          19      19              
- Misses       756     764       +8     
  Partials       3       3              
Files Coverage Δ
pkg/common/db/relation/conversation_model.go 0.00% <0.00%> (ø)

cubxxw
cubxxw previously approved these changes Oct 31, 2023
@cubxxw cubxxw enabled auto-merge October 31, 2023 02:01
@withchao withchao temporarily deployed to openim November 1, 2023 06:26 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 1, 2023 06:26 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 1, 2023 06:26 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 1, 2023 06:26 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 1, 2023 06:26 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 1, 2023 06:26 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 1, 2023 06:26 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 2, 2023 06:19 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 2, 2023 06:19 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 2, 2023 06:19 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 2, 2023 06:19 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 2, 2023 06:19 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 2, 2023 06:19 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim November 2, 2023 06:19 — with GitHub Actions Inactive
@cubxxw cubxxw added this pull request to the merge queue Nov 2, 2023
Merged via the queue into openimsdk:main with commit 62e9980 Nov 2, 2023
18 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Nov 2, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Other]: scheduled task splitting
3 participants