Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use dummy pusher by default #1349

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

a3d21
Copy link
Contributor

@a3d21 a3d21 commented Nov 6, 2023

Default to using DummyPusher.

@a3d21 a3d21 requested review from skiffer-git, FGadvancer and a team as code owners November 6, 2023 09:13
@a3d21 a3d21 requested a review from Bloomingg November 6, 2023 09:13
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 6, 2023
@kubbot
Copy link
Contributor

kubbot commented Nov 6, 2023

CLA Assistant Lite bot: 💕 Thank you for your contribution and please kindly read and sign our 🎯https://github.com/openim-sigs/cla/blob/main/README.md.
If you wish to sign the CRA, Please copy and comment on the following sentence:


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

Copy link
Contributor

sweep-ai bot commented Nov 6, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #1349 (dc03be5) into main (1aef30d) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #1349   +/-   ##
=====================================
  Coverage   2.41%   2.41%           
=====================================
  Files         13      13           
  Lines        786     786           
=====================================
  Hits          19      19           
  Misses       764     764           
  Partials       3       3           

@FGadvancer FGadvancer added this pull request to the merge queue Nov 7, 2023
Merged via the queue into openimsdk:main with commit 297a8db Nov 7, 2023
17 of 18 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Nov 7, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants