Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync close ws conn when kick old user avoid wrong trigger order … #1368

Merged

Conversation

FGadvancer
Copy link
Member

…about online status.


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #693

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Copy link
Contributor

sweep-ai bot commented Nov 8, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #1368 (a1aba2a) into main (82a8f33) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #1368   +/-   ##
=====================================
  Coverage   2.41%   2.41%           
=====================================
  Files         13      13           
  Lines        786     786           
=====================================
  Hits          19      19           
  Misses       764     764           
  Partials       3       3           

@cubxxw cubxxw enabled auto-merge November 8, 2023 10:16
@cubxxw cubxxw added this pull request to the merge queue Nov 8, 2023
Merged via the queue into openimsdk:main with commit b562da5 Nov 8, 2023
18 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Nov 8, 2023
@github-actions github-actions bot added this to the v3.1 milestone Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants