-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: gin prometheus for api #1371
Merged
openimbot
merged 1 commit into
openimsdk:main
from
rfyiamcool:refactor/gin_prometheus_for_api
Nov 13, 2023
Merged
refactor: gin prometheus for api #1371
openimbot
merged 1 commit into
openimsdk:main
from
rfyiamcool:refactor/gin_prometheus_for_api
Nov 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Nov 9, 2023
Apply Sweep Rules to your PR?
|
Codecov Report
@@ Coverage Diff @@
## main #1371 +/- ##
=====================================
Coverage 4.30% 4.30%
=====================================
Files 45 45
Lines 3809 3809
=====================================
Hits 164 164
Misses 3634 3634
Partials 11 11 |
cubxxw
previously approved these changes
Nov 10, 2023
rfyiamcool
force-pushed
the
refactor/gin_prometheus_for_api
branch
from
November 13, 2023 03:24
7c418c7
to
3d990b3
Compare
rfyiamcool
requested review from
skiffer-git,
FGadvancer,
a team,
Bloomingg and
withchao
as code owners
November 13, 2023 03:24
rfyiamcool
force-pushed
the
refactor/gin_prometheus_for_api
branch
from
November 13, 2023 03:51
3d990b3
to
8b005f3
Compare
Signed-off-by: rfyiamcool <rfyiamcool@163.com>
rfyiamcool
force-pushed
the
refactor/gin_prometheus_for_api
branch
from
November 13, 2023 04:17
8b005f3
to
3c9fd05
Compare
cubxxw
approved these changes
Nov 13, 2023
openimbot
approved these changes
Nov 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
io.ioutil
is deprecated in go1.16./article/:uid
url, don't need/article/13183?page_index=10&page=100&q=xxx&order=desc
. when the url is randomized, this design is not friendly to prome storage and does not display well in grafana.