Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/fix online status sync trigger #1393

Merged

Conversation

FGadvancer
Copy link
Collaborator


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Copy link
Contributor

sweep-ai bot commented Nov 13, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #1393 (6607f5e) into main (2ac54e0) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff          @@
##            main   #1393   +/-   ##
=====================================
  Coverage   4.37%   4.37%           
=====================================
  Files         49      49           
  Lines       4090    4090           
=====================================
  Hits         179     179           
  Misses      3899    3899           
  Partials      12      12           
Files Coverage Δ
pkg/msgprocessor/conversation.go 0.00% <0.00%> (ø)

Copy link
Collaborator

@withchao withchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1

@withchao withchao self-requested a review November 14, 2023 01:35
Copy link
Collaborator

@withchao withchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1

@withchao withchao added this pull request to the merge queue Nov 14, 2023
Merged via the queue into openimsdk:main with commit 7698368 Nov 14, 2023
22 checks passed
@withchao withchao deleted the bug/fix_online_status_sync_trigger branch November 14, 2023 02:01
@openimsdk openimsdk locked and limited conversation to collaborators Nov 14, 2023
@github-actions github-actions bot added this to the v3.1 milestone Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants