Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: grace shutdown for api server #1439

Merged
merged 2 commits into from
Nov 26, 2023

Conversation

rfyiamcool
Copy link
Contributor

summary

add graceful shutdown operation for open-im api server.

Signed-off-by: rfyiamcool <rfyiamcool@163.com>
Signed-off-by: rfyiamcool <rfyiamcool@163.com>
Copy link
Contributor

sweep-ai bot commented Nov 19, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (75375ad) 4.54% compared to head (848b6c4) 4.54%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1439   +/-   ##
=====================================
  Coverage   4.54%   4.54%           
=====================================
  Files         49      49           
  Lines       4140    4140           
=====================================
  Hits         188     188           
  Misses      3940    3940           
  Partials      12      12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rfyiamcool rfyiamcool changed the title Fix/grace shutdown for api server fix: grace shutdown for api server Nov 20, 2023
@cubxxw cubxxw added this pull request to the merge queue Nov 26, 2023
Merged via the queue into openimsdk:main with commit 3cecbbc Nov 26, 2023
21 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Nov 26, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants