Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong single message read state. #1443

Merged
merged 4 commits into from
Nov 26, 2023

Conversation

FGadvancer
Copy link
Member


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1441

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Copy link
Contributor

sweep-ai bot commented Nov 20, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (75375ad) 4.54% compared to head (1334487) 4.97%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1443      +/-   ##
========================================
+ Coverage   4.54%   4.97%   +0.43%     
========================================
  Files         49      49              
  Lines       4140    4162      +22     
========================================
+ Hits         188     207      +19     
- Misses      3940    3943       +3     
  Partials      12      12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 26, 2023
cubxxw
cubxxw previously approved these changes Nov 26, 2023
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 26, 2023
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2023
@kubbot kubbot disabled auto-merge November 26, 2023 12:47
@kubbot kubbot added this pull request to the merge queue Nov 26, 2023
Merged via the queue into openimsdk:main with commit f935d36 Nov 26, 2023
22 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Nov 26, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: single message read state is wrong sometimes.
5 participants