-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enhance Template Generation Logic in OPENIM Deployment Scripts #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cubxxw
requested review from
Bloomingg,
FGadvancer,
skiffer-git,
withchao and
a team
as code owners
December 1, 2023 08:51
pull-request-size
bot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Dec 1, 2023
Apply Sweep Rules to your PR?
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1510 +/- ##
=====================================
Coverage 4.86% 4.86%
=====================================
Files 49 49
Lines 4256 4256
=====================================
Hits 207 207
Misses 4037 4037
Partials 12 12 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
pull-request-size
bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Dec 4, 2023
skiffer-git
approved these changes
Dec 4, 2023
openimbot
approved these changes
Dec 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This PR introduces significant improvements to the template generation process in the OPENIM deployment scripts. The changes are focused on enhancing user interaction and information dissemination during the configuration phase.
Changes:
https://github.com/openimsdk/open-im-server/blob/main/docs/contrib/environment.md
) has been added. This provides users with quick access to detailed configuration information.Y
), the script proceeds with the generation and informs the user that the previous configuration will be lost.N
), the script skips the generation of that particular file and moves on, ensuring existing configurations are preserved.Impact:
Rationale: These changes address two key aspects: