Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add openim docker compose and env #1550

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Dec 11, 2023


🔍 What type of PR is this?

/kind documentation
/kind feature

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

I would greatly appreciate it if you could assist us in improving the design of the Docker Compose startup process, as well as automating it and implementing environment variable retrieval.

🅰 Which issue(s) this PR fixes:

Link: #1514, #1513, #1504

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 11, 2023
Copy link
Contributor

sweep-ai bot commented Dec 11, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb64626) 4.88% compared to head (8f58b95) 4.88%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1550   +/-   ##
=====================================
  Coverage   4.88%   4.88%           
=====================================
  Files         42      42           
  Lines       3787    3787           
=====================================
  Hits         185     185           
  Misses      3592    3592           
  Partials      10      10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
@pull-request-size pull-request-size bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 11, 2023
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

skiffer-git
skiffer-git previously approved these changes Dec 11, 2023
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
@cubxxw cubxxw added this pull request to the merge queue Dec 12, 2023
Merged via the queue into openimsdk:main with commit bb44633 Dec 12, 2023
20 checks passed
@cubxxw cubxxw deleted the feat/env-optimization branch December 12, 2023 08:44
@github-actions github-actions bot added this to the v3.1 milestone Dec 12, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants