Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check-all.sh #1591

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Update check-all.sh #1591

merged 1 commit into from
Dec 25, 2023

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Dec 20, 2023


🔍 What type of PR is this?

/kind documentation
/kind feature

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

I kindly request your assistance with the local -n issue. It seems that the bash version is too outdated to support this feature. Thank you for your attention to this matter.

🅰 Which issue(s) this PR fixes:

Fixes #

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Copy link
Contributor

sweep-ai bot commented Dec 20, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed5f012) 5.15% compared to head (e675c89) 5.15%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1591   +/-   ##
=====================================
  Coverage   5.15%   5.15%           
=====================================
  Files         42      42           
  Lines       3760    3760           
=====================================
  Hits         194     194           
  Misses      3555    3555           
  Partials      11      11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cubxxw cubxxw added this pull request to the merge queue Dec 25, 2023
Merged via the queue into main with commit f105280 Dec 25, 2023
26 checks passed
@cubxxw cubxxw deleted the cubxxw-patch-2 branch December 25, 2023 08:27
@github-actions github-actions bot added this to the v3.1 milestone Dec 25, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants