Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add syncself for some notifications. #1609

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

FGadvancer
Copy link
Member

@FGadvancer FGadvancer commented Dec 26, 2023


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Copy link
Contributor

sweep-ai bot commented Dec 26, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ed5f012) 5.15% compared to head (9247c13) 5.16%.
Report is 5 commits behind head on main.

Files Patch % Lines
pkg/msgprocessor/options.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1609   +/-   ##
=====================================
  Coverage   5.15%   5.16%           
=====================================
  Files         42      42           
  Lines       3760    3755    -5     
=====================================
  Hits         194     194           
+ Misses      3555    3550    -5     
  Partials      11      11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FGadvancer FGadvancer added this pull request to the merge queue Dec 27, 2023
Merged via the queue into openimsdk:main with commit 53a3f47 Dec 27, 2023
22 checks passed
@FGadvancer FGadvancer deleted the main-new branch December 27, 2023 16:42
@github-actions github-actions bot added this to the v3.1 milestone Dec 27, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Dec 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants