Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support websocket first message method response code #1651

Merged
merged 24 commits into from
Jan 2, 2024
Merged

feat: support websocket first message method response code #1651

merged 24 commits into from
Jan 2, 2024

Conversation

withchao
Copy link
Contributor

@withchao withchao commented Jan 2, 2024


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1650

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 2, 2024
Copy link
Contributor

sweep-ai bot commented Jan 2, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 64 lines in your changes are missing coverage. Please review.

Comparison is base (49f4e3f) 5.12% compared to head (2d295e2) 5.11%.

Files Patch % Lines
internal/msggateway/n_ws_server.go 0.00% 64 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1651      +/-   ##
========================================
- Coverage   5.12%   5.11%   -0.02%     
========================================
  Files         42      42              
  Lines       3782    3792      +10     
========================================
  Hits         194     194              
- Misses      3577    3587      +10     
  Partials      11      11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@withchao withchao added this pull request to the merge queue Jan 2, 2024
Merged via the queue into openimsdk:main with commit 3fffc2f Jan 2, 2024
21 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Jan 2, 2024
@openimsdk openimsdk locked and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Other]: support websocket first message method response code
3 participants