Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix the getSortedConversationList api #1729

Merged
merged 2 commits into from
Jan 10, 2024
Merged

fix: fix the getSortedConversationList api #1729

merged 2 commits into from
Jan 10, 2024

Conversation

luhaoling
Copy link
Contributor

@luhaoling luhaoling commented Jan 9, 2024 •
edited
Loading


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1724

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 9, 2024
@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Jan 9, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@cubxxw cubxxw merged commit 571e239 into openimsdk:release-v3.5 Jan 10, 2024
9 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Jan 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewZuo01 AndrewZuo01 AndrewZuo01 approved these changes

@FGadvancer FGadvancer FGadvancer approved these changes

@skiffer-git skiffer-git Awaiting requested review from skiffer-git skiffer-git is a code owner

@cubxxw cubxxw Awaiting requested review from cubxxw

@Bloomingg Bloomingg Awaiting requested review from Bloomingg Bloomingg is a code owner

@withchao withchao Awaiting requested review from withchao withchao is a code owner

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luhaoling @FGadvancer @AndrewZuo01 @cubxxw