Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NotificationUserInfoUpdate not notified #1747

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

withchao
Copy link
Contributor

(cherry picked from commit 48ff03f)


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1746

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

(cherry picked from commit 48ff03f)
@withchao withchao requested review from Bloomingg and removed request for a team January 12, 2024 03:22
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (07dfde9) 5.10% compared to head (a412ab3) 5.10%.
Report is 1 commits behind head on release-v3.5.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-v3.5   #1747   +/-   ##
============================================
  Coverage          5.10%   5.10%           
============================================
  Files                42      42           
  Lines              3797    3797           
============================================
  Hits                194     194           
  Misses             3592    3592           
  Partials             11      11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

sweep-ai bot commented Jan 12, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

This is an automated message generated by Sweep AI.

@cubxxw cubxxw merged commit d236f40 into openimsdk:release-v3.5 Jan 12, 2024
12 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants