Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add table of sending message for set message status on weak net . #398

Merged

Conversation

FGadvancer
Copy link
Collaborator


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #397

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Signed-off-by: Gordon <46924906+FGadvancer@users.noreply.github.com>
@FGadvancer FGadvancer requested a review from a team as a code owner November 2, 2023 03:57
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 2, 2023
@FGadvancer FGadvancer temporarily deployed to openim November 2, 2023 03:57 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim November 2, 2023 03:57 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim November 2, 2023 03:57 — with GitHub Actions Inactive
@FGadvancer FGadvancer temporarily deployed to openim November 2, 2023 03:57 — with GitHub Actions Inactive
Copy link

sweep-ai bot commented Nov 2, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@FGadvancer FGadvancer merged commit 01f704b into openimsdk:main Nov 2, 2023
6 checks passed
@FGadvancer FGadvancer deleted the bug/fix_message_status_weak_net branch November 2, 2023 04:04
0xryanz pushed a commit to sn-dev-be/openim-sdk-core that referenced this pull request Nov 3, 2023
… . (openimsdk#398)

Signed-off-by: Gordon <46924906+FGadvancer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: some messages always sending on weak net.
1 participant