TACODEV-774: enable metric on argo series #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zugwan
requested changes
Jul 2, 2021
intelliguy
force-pushed
the
dev_argo_metric
branch
from
04ef6a9
to
619b514
Compare
|
argo-workflow v3 로 가면서 사용하는 차트가 바뀌어서 value override하는 부분에서 문제가 있을것 같습니다ㅠ |
|
This PR is stale because it has been open 3 days with no activity. Remove stale label or comment or this will be closed in 3 days. |
estherk0
reviewed
Jul 6, 2021
Comment on lines
29
to
30
| metricsConfig: | ||
| enabled: true |
There was a problem hiding this comment.
이 부분 잘 못 들어간 것 같습니다. 밑에 있는 metricsConfig: 랑 겹치는데 삭제해도 되지 않을까요?
There was a problem hiding this comment.
네 맞네요...수정해서 올리겠습니다.
zugwan
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Argo worflow/CD도 prometheus metric으로 수집할 수 있다. Argo worklfow/CD의 metric을 조사하고, Argo CD 의 주요 metric 수집한다.
argo cd/workflow exporter 존재함, 서비스 모니터 생성해서 prometheus로 데이터 저장 확인 (lma-addons)
grafana dashboard 까지 추가, 확인 (grafana labs에 있는 대시보드 활용)
Doing with this PR
argo 설치시 metric을 생성할 수 있도록 설정