Skip to content

Commit 486d6f6

Browse files
committed
8256363: Define toString() for MGF1ParameterSpec
Reviewed-by: mullan
1 parent eab170c commit 486d6f6

File tree

3 files changed

+15
-11
lines changed

3 files changed

+15
-11
lines changed

src/java.base/share/classes/java/security/spec/MGF1ParameterSpec.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@
2525

2626
package java.security.spec;
2727

28-
import java.security.spec.AlgorithmParameterSpec;
29-
3028
/**
3129
* This class specifies the set of parameters used with mask generation
3230
* function MGF1 in OAEP Padding and RSASSA-PSS signature scheme, as
@@ -162,4 +160,9 @@ public MGF1ParameterSpec(String mdName) {
162160
public String getDigestAlgorithm() {
163161
return mdName;
164162
}
163+
164+
@Override
165+
public String toString() {
166+
return "MGF1ParameterSpec[hashAlgorithm=" + mdName + "]";
167+
}
165168
}

src/java.base/share/classes/java/security/spec/PSSParameterSpec.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2001, 2019, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2001, 2020, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -220,11 +220,12 @@ public int getTrailerField() {
220220

221221
@Override
222222
public String toString() {
223-
StringBuilder sb = new StringBuilder();
224-
sb.append("MD: " + mdName + "\n")
225-
.append("MGF: " + mgfSpec + "\n")
226-
.append("SaltLength: " + saltLen + "\n")
227-
.append("TrailerField: " + trailerField + "\n");
223+
StringBuilder sb = new StringBuilder("PSSParameterSpec[");
224+
sb.append("hashAlgorithm=" + mdName + ", ")
225+
.append("maskGenAlgorithm=" + mgfSpec + ", ")
226+
.append("saltLength=" + saltLen + ", ")
227+
.append("trailerField=" + trailerField)
228+
.append(']');
228229
return sb.toString();
229230
}
230231
}

src/java.base/share/classes/sun/security/util/SignatureUtil.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -510,15 +510,15 @@ public static String getDefaultSigAlgForKey(PrivateKey k) {
510510
private static class PSSParamsHolder {
511511
final static PSSParameterSpec PSS_256_SPEC = new PSSParameterSpec(
512512
"SHA-256", "MGF1",
513-
new MGF1ParameterSpec("SHA-256"),
513+
MGF1ParameterSpec.SHA256,
514514
32, PSSParameterSpec.TRAILER_FIELD_BC);
515515
final static PSSParameterSpec PSS_384_SPEC = new PSSParameterSpec(
516516
"SHA-384", "MGF1",
517-
new MGF1ParameterSpec("SHA-384"),
517+
MGF1ParameterSpec.SHA384,
518518
48, PSSParameterSpec.TRAILER_FIELD_BC);
519519
final static PSSParameterSpec PSS_512_SPEC = new PSSParameterSpec(
520520
"SHA-512", "MGF1",
521-
new MGF1ParameterSpec("SHA-512"),
521+
MGF1ParameterSpec.SHA512,
522522
64, PSSParameterSpec.TRAILER_FIELD_BC);
523523
}
524524

0 commit comments

Comments
 (0)