Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242624: Update .jcheck/conf for project Amber (patterns) #15

Closed
wants to merge 1 commit into from
Closed

8242624: Update .jcheck/conf for project Amber (patterns) #15

wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Apr 15, 2020

Hi all,

Please review this change that updates the jcheck configuration for use with Skara tooling.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

  • J. Duke (duke - Author)
  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/amber pull/15/head:pull/15
$ git checkout pull/15

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 15, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into patterns will be added to the body of your pull request.

@openjdk openjdk bot added the rfr Ready for review label Apr 15, 2020
@mlbridge
Copy link

mlbridge bot commented Apr 15, 2020

Webrevs

Copy link

@openjdk-bot openjdk-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@edvbld edvbld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openjdk
Copy link

openjdk bot commented Apr 15, 2020

@rwestberg This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8242624: Update .jcheck/conf for project Amber (patterns)

Reviewed-by: duke, ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message to the patterns branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Apr 15, 2020
@rwestberg
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Apr 15, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated labels Apr 15, 2020
@openjdk
Copy link

openjdk bot commented Apr 15, 2020

@rwestberg
Pushed as commit 7f450ee.

@openjdk openjdk bot removed the rfr Ready for review label Apr 15, 2020
@mlbridge
Copy link

mlbridge bot commented Apr 15, 2020

Mailing list message from Robin Westberg on amber-dev:

Changeset: 7f450ee
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-04-15 11:21:53 +0000
URL: https://git.openjdk.java.net/amber/commit/7f450ee5

8242624: Update .jcheck/conf for project Amber (patterns)

Reviewed-by: duke, ehelin

! .jcheck/conf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants