Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master #72

Closed
wants to merge 129 commits into from
Closed

Merge master #72

wants to merge 129 commits into from

Conversation

openjdk-bot
Copy link

@openjdk-bot openjdk-bot commented Nov 26, 2020

Hi all,

this is an automatically generated pull request to notify you that there are 129 commits from the branch masterthat can not be merged into the branch sealed-types:

The following file contains merge conflicts:

  • src/java.base/share/classes/java/lang/Package.java

All Committers in this project have access to my personal fork and can therefore help resolve these merge conflicts (you may want to coordinate who should do this).
The following paragraphs will give an example on how to solve these merge conflicts and push the resulting merge commit to this pull request.
The below commands should be run in a local clone of your personal fork of the openjdk/amber repository.

# Ensure target branch is up to date
$ git checkout sealed-types
$ git pull https://github.com/openjdk/amber.git sealed-types

# Fetch and checkout the branch for this pull request
$ git fetch https://github.com/openjdk-bot/amber.git +75:openjdk-bot-75
$ git checkout openjdk-bot-75

# Merge the target branch
$ git merge sealed-types

When you have resolved the conflicts resulting from the git merge command above, run the following commands to create a merge commit:

$ git add paths/to/files/with/conflicts
$ git commit -m 'Merge master'

When you have created the merge commit, run the following command to push the merge commit to this pull request:

$ git push https://github.com/openjdk-bot/amber.git openjdk-bot-75:75

Note: if you are using SSH to push commits to GitHub, then change the URL in the above git push command accordingly.

Thanks,
J. Duke


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/amber pull/72/head:pull/72
$ git checkout pull/72

Update a local copy of the PR:
$ git checkout pull/72
$ git pull https://git.openjdk.org/amber pull/72/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 72

View PR using the GUI difftool:
$ git pr show -t 72

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/amber/pull/72.diff

coleenp and others added 30 commits November 19, 2020 22:39
…ld methods should not be in vtable

Reviewed-by: lfoltan, dcubed, dholmes
Reviewed-by: erikj, bchristi, joehw
…T|SA_SIGINFO found:SA_RESTART|SA_SIGINFO

Reviewed-by: stuefe, coleenp, dcubed
…er.java fails

Reviewed-by: cjplummer, sspitsyn
…to access variable sized PtrQueue::_index

Reviewed-by: shade
…useless_nodes missed this node")

Check for nodes missed by remove_useless_nodes() only if PhaseRemoveUseless has
actually been run. This makes it possible to use -XX:-UseLoopSafepoints without
crashing trivially, although implicit assumptions in other parts of C2 about the
existence of loop safepoints might lead to more subtle failures for more complex
methods.

Reviewed-by: neliasso, thartmann, kvn
Reviewed-by: ayang, eosterlund
Reviewed-by: kvn, shade, thartmann
8231547: Serializable class doc should link to serialization specification

Reviewed-by: rriggs, iris, chegar
…rrent code root evacuator

Reviewed-by: rkennke
…e initializing cgroupv1 subsystem

Reviewed-by: shade, sgehwolf, bobv
Reviewed-by: dfuchs, lancea, bpb
shipilev and others added 22 commits November 25, 2020 20:01
Reviewed-by: ayang, stefank
Reviewed-by: ayang, eosterlund, stefank
Reviewed-by: pliden, eosterlund
…in StubGenerator::copy_memory

Reviewed-by: simonis
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 26, 2020

👋 Welcome back duke! A progress list of the required criteria for merging this PR into sealed-types will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added merge-conflict The pull request has a merge conflict with the target branch rfr Ready for review labels Nov 26, 2020
@mlbridge
Copy link

mlbridge bot commented Nov 26, 2020

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 6, 2022

@openjdk-bot This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 3, 2023

@openjdk-bot This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-auto-merge merge-conflict The pull request has a merge conflict with the target branch rfr Ready for review
Development

Successfully merging this pull request may close these issues.