Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master #75

Closed
wants to merge 217 commits into from
Closed

Merge master #75

wants to merge 217 commits into from

Conversation

openjdk-bot
Copy link

@openjdk-bot openjdk-bot commented Dec 31, 2020

Hi all,

this is an automatically generated pull request to notify you that there are 10 commits from the branch masterthat can not be merged into the branch lambda-leftovers:

The following file contains merge conflicts:

  • test/langtools/tools/javac/lambda/UnderscoreAsIdent.java

All Committers in this project have access to my personal fork and can therefore help resolve these merge conflicts (you may want to coordinate who should do this).
The following paragraphs will give an example on how to solve these merge conflicts and push the resulting merge commit to this pull request.
The below commands should be run in a local clone of your personal fork of the openjdk/amber repository.

# Ensure target branch is up to date
$ git checkout lambda-leftovers
$ git pull https://github.com/openjdk/amber.git lambda-leftovers

# Fetch and checkout the branch for this pull request
$ git fetch https://github.com/openjdk-bot/amber.git +78:openjdk-bot-78
$ git checkout openjdk-bot-78

# Merge the target branch
$ git merge lambda-leftovers

When you have resolved the conflicts resulting from the git merge command above, run the following commands to create a merge commit:

$ git add paths/to/files/with/conflicts
$ git commit -m 'Merge master'

When you have created the merge commit, run the following command to push the merge commit to this pull request:

$ git push https://github.com/openjdk-bot/amber.git openjdk-bot-78:78

Note: if you are using SSH to push commits to GitHub, then change the URL in the above git push command accordingly.

Thanks,
J. Duke


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/amber pull/75/head:pull/75
$ git checkout pull/75

Update a local copy of the PR:
$ git checkout pull/75
$ git pull https://git.openjdk.org/amber pull/75/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 75

View PR using the GUI difftool:
$ git pr show -t 75

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/amber/pull/75.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 31, 2020

👋 Welcome back duke! A progress list of the required criteria for merging this PR into lambda-leftovers will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added merge-conflict The pull request has a merge conflict with the target branch rfr Ready for review labels Dec 31, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 31, 2020

Webrevs

ChrisHegarty and others added 15 commits January 2, 2021 19:29
…ccording to primitive size

Reviewed-by: alanb
Reviewed-by: wetmore
mahendrachhipa and others added 27 commits January 13, 2021 15:53
…class unloading

Reviewed-by: pliden, neliasso
…found in unbound lookup' when resolving method reference

Reviewed-by: mcimadamore
…ialFocusTest1.java on Windows

Reviewed-by: kizune, pbansal
…ndCP_JFR.java on Windows

Reviewed-by: pliden
…gner’s cert chain

Reviewed-by: mullan, weijun, rhalade
…alid_vtable_index) failed: correct sentinel value

Reviewed-by: lucy, chagedorn
…tion requests

Reviewed-by: dholmes, coleenp
Reviewed-by: coleenp, lfoltan, shade
Reviewed-by: erikj, weijun, mullan
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 6, 2022

@openjdk-bot This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 3, 2023

@openjdk-bot This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-auto-merge merge-conflict The pull request has a merge conflict with the target branch rfr Ready for review
Development

Successfully merging this pull request may close these issues.