Skip to content

Commit 6fe209b

Browse files
committed
8254671: ZGC: Remove unused roots iterator types
Reviewed-by: stefank
1 parent 9c93490 commit 6fe209b

File tree

2 files changed

+0
-52
lines changed

2 files changed

+0
-52
lines changed

src/hotspot/share/gc/z/zRootsIterator.cpp

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
#include "gc/shared/barrierSet.hpp"
3030
#include "gc/shared/barrierSetNMethod.hpp"
3131
#include "gc/shared/oopStorageSet.hpp"
32-
#include "gc/shared/oopStorageParState.inline.hpp"
3332
#include "gc/shared/oopStorageSetParState.inline.hpp"
3433
#include "gc/shared/suspendibleThreadSet.hpp"
3534
#include "gc/z/zBarrierSetNMethod.hpp"
@@ -62,18 +61,6 @@ static const ZStatSubPhase ZSubPhaseConcurrentRootsCodeCache("Concurrent Roots C
6261
static const ZStatSubPhase ZSubPhasePauseWeakRootsJVMTIWeakExport("Pause Weak Roots JVMTIWeakExport");
6362
static const ZStatSubPhase ZSubPhaseConcurrentWeakRootsOopStorageSet("Concurrent Weak Roots OopStorageSet");
6463

65-
template <typename T, void (T::*F)(ZRootsIteratorClosure*)>
66-
ZSerialOopsDo<T, F>::ZSerialOopsDo(T* iter) :
67-
_iter(iter),
68-
_claimed(false) {}
69-
70-
template <typename T, void (T::*F)(ZRootsIteratorClosure*)>
71-
void ZSerialOopsDo<T, F>::oops_do(ZRootsIteratorClosure* cl) {
72-
if (!_claimed && Atomic::cmpxchg(&_claimed, false, true) == false) {
73-
(_iter->*F)(cl);
74-
}
75-
}
76-
7764
template <typename T, void (T::*F)(ZRootsIteratorClosure*)>
7865
ZParallelOopsDo<T, F>::ZParallelOopsDo(T* iter) :
7966
_iter(iter),
@@ -101,21 +88,6 @@ void ZSerialWeakOopsDo<T, F>::weak_oops_do(BoolObjectClosure* is_alive, ZRootsIt
10188
}
10289
}
10390

104-
template <typename T, void (T::*F)(BoolObjectClosure*, ZRootsIteratorClosure*)>
105-
ZParallelWeakOopsDo<T, F>::ZParallelWeakOopsDo(T* iter) :
106-
_iter(iter),
107-
_completed(false) {}
108-
109-
template <typename T, void (T::*F)(BoolObjectClosure*, ZRootsIteratorClosure*)>
110-
void ZParallelWeakOopsDo<T, F>::weak_oops_do(BoolObjectClosure* is_alive, ZRootsIteratorClosure* cl) {
111-
if (!_completed) {
112-
(_iter->*F)(is_alive, cl);
113-
if (!_completed) {
114-
_completed = true;
115-
}
116-
}
117-
}
118-
11991
ZJavaThreadsIterator::ZJavaThreadsIterator() :
12092
_threads(),
12193
_claimed(0) {}

src/hotspot/share/gc/z/zRootsIterator.hpp

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
#ifndef SHARE_GC_Z_ZROOTSITERATOR_HPP
2525
#define SHARE_GC_Z_ZROOTSITERATOR_HPP
2626

27-
#include "gc/shared/oopStorageParState.hpp"
2827
#include "gc/shared/oopStorageSetParState.hpp"
2928
#include "gc/shared/suspendibleThreadSet.hpp"
3029
#include "memory/allocation.hpp"
@@ -35,21 +34,9 @@
3534

3635
class ZRootsIteratorClosure;
3736

38-
typedef OopStorage::ParState<true /* concurrent */, false /* is_const */> ZOopStorageIterator;
3937
typedef OopStorageSetStrongParState<true /* concurrent */, false /* is_const */> ZOopStorageSetStrongIterator;
4038
typedef OopStorageSetWeakParState<true /* concurrent */, false /* is_const */> ZOopStorageSetWeakIterator;
4139

42-
template <typename T, void (T::*F)(ZRootsIteratorClosure*)>
43-
class ZSerialOopsDo {
44-
private:
45-
T* const _iter;
46-
volatile bool _claimed;
47-
48-
public:
49-
ZSerialOopsDo(T* iter);
50-
void oops_do(ZRootsIteratorClosure* cl);
51-
};
52-
5340
template <typename T, void (T::*F)(ZRootsIteratorClosure*)>
5441
class ZParallelOopsDo {
5542
private:
@@ -72,17 +59,6 @@ class ZSerialWeakOopsDo {
7259
void weak_oops_do(BoolObjectClosure* is_alive, ZRootsIteratorClosure* cl);
7360
};
7461

75-
template <typename T, void (T::*F)(BoolObjectClosure*, ZRootsIteratorClosure*)>
76-
class ZParallelWeakOopsDo {
77-
private:
78-
T* const _iter;
79-
volatile bool _completed;
80-
81-
public:
82-
ZParallelWeakOopsDo(T* iter);
83-
void weak_oops_do(BoolObjectClosure* is_alive, ZRootsIteratorClosure* cl);
84-
};
85-
8662
class ZRootsIteratorClosure : public OopClosure {
8763
public:
8864
virtual void do_thread(Thread* thread) {}

0 commit comments

Comments
 (0)