Skip to content

Commit 96a1f08

Browse files
committed
8254775: Microbenchmark StringIndexOfChar doesn't compile
Reviewed-by: rriggs
1 parent a6a3813 commit 96a1f08

File tree

1 file changed

+18
-18
lines changed

1 file changed

+18
-18
lines changed

test/micro/org/openjdk/bench/java/lang/StringIndexOfChar.java

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
@BenchmarkMode(Mode.AverageTime)
4141
@OutputTimeUnit(TimeUnit.NANOSECONDS)
4242
@State(Scope.Thread)
43-
public class IndexOfBenchmark {
43+
public class StringIndexOfChar {
4444
private static final int loops = 100000;
4545
private static final Random rng = new Random(1999);
4646
private static final int pathCnt = 1000;
@@ -68,7 +68,7 @@ public class IndexOfBenchmark {
6868
private static String makeRndString(boolean isUtf16, int length) {
6969
StringBuilder sb = new StringBuilder(length);
7070
if(length > 0){
71-
sb.append(isUtf16?'':'b');
71+
sb.append(isUtf16?'\u2026':'b'); // ...
7272

7373
for (int i = 1; i < length-1; i++) {
7474
sb.append((char)('b' + rng.nextInt(26)));
@@ -81,31 +81,31 @@ private static String makeRndString(boolean isUtf16, int length) {
8181

8282

8383
@Benchmark
84-
public static void latin1_mixed_char() {
84+
public void latin1_mixed_char() {
8585
int ret = 0;
8686
for (String what : latn1_mixedLength) {
8787
ret += what.indexOf('a');
8888
}
8989
}
9090

9191
@Benchmark
92-
public static void utf16_mixed_char() {
92+
public void utf16_mixed_char() {
9393
int ret = 0;
9494
for (String what : utf16_mixedLength) {
9595
ret += what.indexOf('a');
9696
}
9797
}
9898

9999
@Benchmark
100-
public static void latin1_mixed_String() {
100+
public void latin1_mixed_String() {
101101
int ret = 0;
102102
for (String what : latn1_mixedLength) {
103103
ret += what.indexOf("a");
104104
}
105105
}
106106

107107
@Benchmark
108-
public static void utf16_mixed_String() {
108+
public void utf16_mixed_String() {
109109
int ret = 0;
110110
for (String what : utf16_mixedLength) {
111111
ret += what.indexOf("a");
@@ -115,31 +115,31 @@ public static void utf16_mixed_String() {
115115
////////// more detailed code path dependent tests //////////
116116

117117
@Benchmark
118-
public static void latin1_Short_char() {
118+
public void latin1_Short_char() {
119119
int ret = 0;
120120
for (String what : latn1_short) {
121121
ret += what.indexOf('a');
122122
}
123123
}
124124

125125
@Benchmark
126-
public static void latin1_SSE4_char() {
126+
public void latin1_SSE4_char() {
127127
int ret = 0;
128128
for (String what : latn1_sse4) {
129129
ret += what.indexOf('a');
130130
}
131131
}
132132

133133
@Benchmark
134-
public static void latin1_AVX2_char() {
134+
public void latin1_AVX2_char() {
135135
int ret = 0;
136136
for (String what : latn1_avx2) {
137137
ret += what.indexOf('a');
138138
}
139139
}
140140

141141
@Benchmark
142-
public static int utf16_Short_char() {
142+
public int utf16_Short_char() {
143143
int ret = 0;
144144
for (String what : utf16_short) {
145145
ret += what.indexOf('a');
@@ -148,7 +148,7 @@ public static int utf16_Short_char() {
148148
}
149149

150150
@Benchmark
151-
public static int utf16_SSE4_char() {
151+
public int utf16_SSE4_char() {
152152
int ret = 0;
153153
for (String what : utf16_sse4) {
154154
ret += what.indexOf('a');
@@ -157,7 +157,7 @@ public static int utf16_SSE4_char() {
157157
}
158158

159159
@Benchmark
160-
public static int utf16_AVX2_char() {
160+
public int utf16_AVX2_char() {
161161
int ret = 0;
162162
for (String what : utf16_avx2) {
163163
ret += what.indexOf('a');
@@ -166,7 +166,7 @@ public static int utf16_AVX2_char() {
166166
}
167167

168168
@Benchmark
169-
public static int latin1_Short_String() {
169+
public int latin1_Short_String() {
170170
int ret = 0;
171171
for (String what : latn1_short) {
172172
ret += what.indexOf("a");
@@ -175,7 +175,7 @@ public static int latin1_Short_String() {
175175
}
176176

177177
@Benchmark
178-
public static int latin1_SSE4_String() {
178+
public int latin1_SSE4_String() {
179179
int ret = 0;
180180
for (String what : latn1_sse4) {
181181
ret += what.indexOf("a");
@@ -184,7 +184,7 @@ public static int latin1_SSE4_String() {
184184
}
185185

186186
@Benchmark
187-
public static int latin1_AVX2_String() {
187+
public int latin1_AVX2_String() {
188188
int ret = 0;
189189
for (String what : latn1_avx2) {
190190
ret += what.indexOf("a");
@@ -193,7 +193,7 @@ public static int latin1_AVX2_String() {
193193
}
194194

195195
@Benchmark
196-
public static int utf16_Short_String() {
196+
public int utf16_Short_String() {
197197
int ret = 0;
198198
for (String what : utf16_short) {
199199
ret += what.indexOf("a");
@@ -202,7 +202,7 @@ public static int utf16_Short_String() {
202202
}
203203

204204
@Benchmark
205-
public static int utf16_SSE4_String() {
205+
public int utf16_SSE4_String() {
206206
int ret = 0;
207207
for (String what : utf16_sse4) {
208208
ret += what.indexOf("a");
@@ -211,7 +211,7 @@ public static int utf16_SSE4_String() {
211211
}
212212

213213
@Benchmark
214-
public static int utf16_AVX2_String() {
214+
public int utf16_AVX2_String() {
215215
int ret = 0;
216216
for (String what : utf16_avx2) {
217217
ret += what.indexOf("a");

0 commit comments

Comments
 (0)