Skip to content

Commit 2f74e14

Browse files
Kerem Katshipilev
authored andcommitted
8367862: debug.cpp: Do not print help message for methods ifdef'd out
Reviewed-by: mhaessig, kevinw, shade, phh
1 parent e365b7d commit 2f74e14

File tree

1 file changed

+43
-18
lines changed

1 file changed

+43
-18
lines changed

src/hotspot/share/utilities/debug.cpp

Lines changed: 43 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -651,33 +651,58 @@ void pp(oop p) { pp((void*)p); }
651651
void help() {
652652
Command c("help");
653653
tty->print_cr("basic");
654-
tty->print_cr(" pp(void* p) - try to make sense of p");
655-
tty->print_cr(" ps() - print current thread stack");
656-
tty->print_cr(" pss() - print all thread stacks");
657-
tty->print_cr(" pm(int pc) - print Method* given compiled PC");
658-
tty->print_cr(" findm(intptr_t pc) - finds Method*");
659-
tty->print_cr(" find(intptr_t x) - finds & prints nmethod/stub/bytecode/oop based on pointer into it");
660-
tty->print_cr(" pns(void* sp, void* fp, void* pc) - print native (i.e. mixed) stack trace. E.g.");
661-
tty->print_cr(" pns($sp, $rbp, $pc) on Linux/amd64 or");
662-
tty->print_cr(" pns($sp, $ebp, $pc) on Linux/x86 or");
663-
tty->print_cr(" pns($sp, $fp, $pc) on Linux/AArch64 or");
664-
tty->print_cr(" pns($sp, 0, $pc) on Linux/ppc64 or");
665-
tty->print_cr(" pns($sp, $s8, $pc) on Linux/mips or");
666-
tty->print_cr(" pns($sp, $fp, $pc) on Linux/RISC-V");
654+
tty->print_cr(" pp(void* p) - try to make sense of p");
655+
tty->print_cr(" ps() - print current thread stack");
656+
tty->print_cr(" pss() - print all thread stacks");
657+
tty->print_cr(" pm(int pc) - print Method* given compiled PC");
658+
tty->print_cr(" findnm(intptr_t pc) - find nmethod*");
659+
tty->print_cr(" findm(intptr_t pc) - find Method*");
660+
tty->print_cr(" find(intptr_t x) - find & print nmethod/stub/bytecode/oop based on pointer into it");
661+
tty->print_cr(" findpc(intptr_t x) - find & print nmethod/stub/bytecode/oop based on pointer into it (verbose)");
662+
663+
#ifndef PRODUCT
664+
tty->print_cr(" pns(void* sp, void* fp, void* pc) - print native (i.e. mixed) stack trace, e.g.");
665+
#ifdef LINUX
666+
AMD64_ONLY( tty->print_cr(" pns($sp, $rbp, $pc) on Linux/amd64"));
667+
IA32_ONLY( tty->print_cr(" pns($sp, $ebp, $pc) on Linux/x86"));
668+
AARCH64_ONLY(tty->print_cr(" pns($sp, $fp, $pc) on Linux/AArch64"));
669+
RISCV_ONLY( tty->print_cr(" pns($sp, $fp, $pc) on Linux/RISC-V"));
670+
PPC64_ONLY( tty->print_cr(" pns($sp, 0, $pc) on Linux/ppc64"));
671+
#endif // LINUX
667672
tty->print_cr(" - in gdb do 'set overload-resolution off' before calling pns()");
668673
tty->print_cr(" - in dbx do 'frame 1' before calling pns()");
674+
#endif // !PRODUCT
675+
676+
tty->print_cr("universe.");
677+
tty->print_cr(" verify(intptr_t p) - run verify on Universe");
678+
tty->print_cr(" threads() - print all threads");
679+
tty->print_cr(" psd() - print system dictionary");
680+
669681
tty->print_cr("class metadata.");
670682
tty->print_cr(" findclass(name_pattern, flags)");
671683
tty->print_cr(" findmethod(class_name_pattern, method_pattern, flags)");
672684

673-
tty->print_cr("misc.");
674-
tty->print_cr(" flush() - flushes the log file");
675-
tty->print_cr(" events() - dump events from ring buffers");
685+
tty->print_cr("method metadata.");
686+
tty->print_cr(" blob(CodeBlob* p) - print CodeBlob");
687+
tty->print_cr(" dump_vtable(address p) - dump vtable of the Klass");
688+
tty->print_cr(" nm(intptr_t p) - find & print CodeBlob details");
689+
tty->print_cr(" disnm(intptr_t p) - find & print disassembly of CodeBlob");
690+
tty->print_cr(" printnm(intptr_t p) - print nmethod details");
691+
tty->print_cr(" findbcp(method, bcp) - find & prints bcp");
676692

693+
tty->print_cr("stack frame details.");
694+
tty->print_cr(" pfl() - print frame layout");
695+
tty->print_cr(" psf() - print stack frames");
696+
697+
tty->print_cr("misc.");
698+
tty->print_cr(" flush() - flush the log file");
699+
tty->print_cr(" events() - dump events from ring buffers");
700+
tty->print_cr(" u5decode(intptr_t addr) - decode a single u5 value");
701+
tty->print_cr(" u5p(intptr_t addr, intptr_t limit, int count) - decode u5 values");
677702

678703
tty->print_cr("compiler debugging");
679-
tty->print_cr(" debug() - to set things up for compiler debugging");
680-
tty->print_cr(" ndebug() - undo debug");
704+
tty->print_cr(" debug() - set things up for compiler debugging");
705+
tty->print_cr(" ndebug() - undo debug");
681706
}
682707

683708
#ifndef PRODUCT

0 commit comments

Comments
 (0)