Skip to content

Commit cacce84

Browse files
committed
8169954: JFileChooser/8021253: java.lang.RuntimeException: Default button is not pressed
Reviewed-by: serb
1 parent 7597cba commit cacce84

File tree

2 files changed

+29
-22
lines changed

2 files changed

+29
-22
lines changed

test/jdk/ProblemList.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -768,7 +768,6 @@ javax/swing/text/JTextComponent/5074573/bug5074573.java 8196100 windows-all
768768
javax/swing/JFileChooser/6798062/bug6798062.java 8146446 windows-all
769769
javax/swing/JComboBox/8182031/ComboPopupTest.java 8196465 linux-all,macosx-all
770770
javax/swing/JFileChooser/6738668/bug6738668.java 8194946 generic-all
771-
javax/swing/JFileChooser/8021253/bug8021253.java 8169954 windows-all,linux-all,macosx-all
772771
javax/swing/JFileChooser/8062561/bug8062561.java 8196466 linux-all,macosx-all
773772
javax/swing/JInternalFrame/Test6325652.java 8224977 macosx-all
774773
javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java 8225045 linux-all

test/jdk/javax/swing/JFileChooser/8021253/bug8021253.java

Lines changed: 29 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -47,42 +47,49 @@ public class bug8021253 {
4747
private static volatile boolean defaultKeyPressed;
4848
private static JFileChooser fileChooser;
4949
private static File file;
50+
private static JFrame frame;
5051

5152
public static void main(String[] args) throws Exception {
53+
try {
54+
Robot robot = new Robot();
55+
robot.setAutoDelay(100);
5256

53-
Robot robot = new Robot();
54-
robot.setAutoDelay(50);
55-
56-
SwingUtilities.invokeAndWait(new Runnable() {
57-
public void run() {
58-
createAndShowGUI();
59-
}
60-
});
57+
SwingUtilities.invokeAndWait(new Runnable() {
58+
public void run() {
59+
createAndShowGUI();
60+
}
61+
});
6162

62-
robot.waitForIdle();
63+
robot.waitForIdle();
64+
robot.delay(1000);
6365

64-
SwingUtilities.invokeAndWait(new Runnable() {
65-
public void run() {
66-
fileChooser.setSelectedFile(file);
67-
}
68-
});
66+
SwingUtilities.invokeAndWait(new Runnable() {
67+
public void run() {
68+
fileChooser.setSelectedFile(file);
69+
}
70+
});
6971

70-
robot.waitForIdle();
72+
robot.waitForIdle();
7173

72-
robot.keyPress(KeyEvent.VK_ENTER);
73-
robot.keyRelease(KeyEvent.VK_ENTER);
74-
robot.waitForIdle();
74+
robot.keyPress(KeyEvent.VK_ENTER);
75+
robot.keyRelease(KeyEvent.VK_ENTER);
76+
robot.waitForIdle();
7577

76-
if (!defaultKeyPressed) {
77-
throw new RuntimeException("Default button is not pressed");
78+
if (!defaultKeyPressed) {
79+
throw new RuntimeException("Default button is not pressed");
80+
}
81+
} finally {
82+
if (frame != null) {
83+
SwingUtilities.invokeAndWait(frame::dispose);
84+
}
7885
}
7986
}
8087

8188
private static void createAndShowGUI() {
8289

8390
file = getTempFile();
8491

85-
final JFrame frame = new JFrame("Test");
92+
frame = new JFrame("Test");
8693
frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
8794
frame.setSize(200, 300);
8895

@@ -97,6 +104,7 @@ public void actionPerformed(ActionEvent e) {
97104

98105
frame.getContentPane().add(BorderLayout.CENTER, fileChooser);
99106
frame.setSize(fileChooser.getPreferredSize());
107+
frame.setLocationRelativeTo(null);
100108
frame.setVisible(true);
101109
}
102110

0 commit comments

Comments
 (0)