Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
8257884: Re-enable sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java …
…as automatic test

Reviewed-by: xuelei
  • Loading branch information
RealCLanger committed Dec 9, 2020
1 parent 79f1dfb commit fae7961
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java
Expand Up @@ -26,21 +26,26 @@
import javax.net.SocketFactory;
import javax.net.ssl.SSLSocketFactory;

import jdk.test.lib.Platform;
import jdk.test.lib.util.FileUtils;

/*
* @test
* @bug 8256818 8257670
* @bug 8256818 8257670 8257884
* @summary Test that creating and closing SSL Sockets without bind/connect
* will not leave leaking socket file descriptors
* @library /test/lib
* @run main/manual SSLSocketLeak
* @run main/othervm SSLSocketLeak
*/
// Note: this test is not reliable, run it manually.
public class SSLSocketLeak {

// number of sockets to open/close
private static final int NUM_TEST_SOCK = 500;

// percentage of accepted growth of open handles
private static final int OPEN_HANDLE_GROWTH_THRESHOLD = Platform.isWindows() ? 25 : 10;

public static void main(String[] args) throws IOException {
long fds_start = FileUtils.getProcessHandleCount();
System.out.println("FDs at the beginning: " + fds_start);
Expand All @@ -53,7 +58,7 @@ public static void main(String[] args) throws IOException {
long fds_end = FileUtils.getProcessHandleCount();
System.out.println("FDs in the end: " + fds_end);

if ((fds_end - fds_start) > (NUM_TEST_SOCK / 10)) {
if ((fds_end - fds_start) > (NUM_TEST_SOCK / OPEN_HANDLE_GROWTH_THRESHOLD)) {
throw new RuntimeException("Too many open file descriptors. Looks leaky.");
}
}
Expand Down

1 comment on commit fae7961

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.