8297972: Poly1305 Endianness on ByteBuffer not enforced

[vpaprotsk]

Per rfc7539 Section 2.5, "Read the block as a little-endian number."

sun.security.util.math.intpoly.IntegerPolynomial1305 enforces this on input when input is provided as []byte but not when input is in ByteBuffer

Tested with Poly1305IntrinsicFuzzTest.java from #11338 which compares Poly1305 MAC between ByteBuffer and []byte

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8297972: Poly1305 Endianness on ByteBuffer not enforced

Reviewers

• Jamil Nimeh (@jnimeh - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11463/head:pull/11463
$ git checkout pull/11463

Update a local copy of the PR:
$ git checkout pull/11463
$ git pull https://git.openjdk.org/jdk pull/11463/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11463

View PR using the GUI difftool:
$ git pr show -t 11463

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11463.diff

[bridgekeeper]

👋 Welcome back vpaprotsk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vpaprotsk The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (e21c845b)
• 00: Full (db17dd19)

[bridgekeeper]

@vpaprotsk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[driverkt]

✅

[jnimeh]

Looks good to me.

[openjdk]

@vpaprotsk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297972: Poly1305 Endianness on ByteBuffer not enforced

Reviewed-by: jnimeh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• facd415: 8297757: VarHandles.getStaticFieldFromBaseAndOffset should get the receiver type from VarHandle
• e803855: 8299863: URLFromURITest.java should import org.junit.jupiter.api.Test
• 92d8326: 8299827: Add resolved IP address in connection exception for sockets
• c6d5600: 8038146: Clarify Map.Entry's connection to the underlying map
• b2d3622: 8299896: Reduce enum values of HtmlLinkInfo.Kind
• 623ba5b: 8300653: G1EvacInfo should use common naming scheme for collection set
• 97c611d: 8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM
• 4562b40: 8300682: InstanceKlassMiscStatus is a bad name
• 26410c1: 8281213: Unsafe uses of long and size_t in MemReporterBase::diff_in_current_scale
• eca6479: 8300087: Replace NULL with nullptr in share/cds/
• ... and 14 more: https://git.openjdk.org/jdk/compare/453dbd12ee42731d7ebfd1a856338099429277c8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jnimeh) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[vpaprotsk]

@jnimeh would you mind running this through your tests? The build failures reported above seem unrelated..

[jnimeh]

@vpaprotsk Yes, happy to take it through a regression run on my side. I'll will run it later tonight.

[jnimeh]

@vpaprotsk regression tests completed successfully on my end.

[vpaprotsk]

Thanks @jnimeh

[vpaprotsk]

/integrate

[openjdk]

@vpaprotsk
Your change (at version e21c845) is now ready to be sponsored by a Committer.

[jnimeh]

/sponsor

[openjdk]

Going to push as commit 9d44dd0.
Since your change was applied there have been 24 commits pushed to the master branch:

• facd415: 8297757: VarHandles.getStaticFieldFromBaseAndOffset should get the receiver type from VarHandle
• e803855: 8299863: URLFromURITest.java should import org.junit.jupiter.api.Test
• 92d8326: 8299827: Add resolved IP address in connection exception for sockets
• c6d5600: 8038146: Clarify Map.Entry's connection to the underlying map
• b2d3622: 8299896: Reduce enum values of HtmlLinkInfo.Kind
• 623ba5b: 8300653: G1EvacInfo should use common naming scheme for collection set
• 97c611d: 8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM
• 4562b40: 8300682: InstanceKlassMiscStatus is a bad name
• 26410c1: 8281213: Unsafe uses of long and size_t in MemReporterBase::diff_in_current_scale
• eca6479: 8300087: Replace NULL with nullptr in share/cds/
• ... and 14 more: https://git.openjdk.org/jdk/compare/453dbd12ee42731d7ebfd1a856338099429277c8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jnimeh @vpaprotsk Pushed as commit 9d44dd0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.