-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8306584: Start of release updates for JDK 22 #13567
Conversation
👋 Welcome back darcy! A progress list of the required criteria for merging this PR into |
@jddarcy The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
/issue add JDK-8306585 |
/issue add JDK-8306586 |
@jddarcy |
@jddarcy |
@jddarcy this pull request can not be integrated into git checkout JDK-8306584
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
javac and symbol related changes seem reasonable to me. Two minor comments added for consideration.
src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassFile.java
Outdated
Show resolved
Hide resolved
@@ -89,7 +89,8 @@ static enum SourceTarget { | |||
EIGHTEEN(false, "62.0", "18", Versions::checksrc18), | |||
NINETEEN(false, "63.0", "19", Versions::checksrc19), | |||
TWENTY(false, "64.0", "20", Versions::checksrc20), | |||
TWENTY_ONE(false,"65.0", "21", Versions::checksrc21); | |||
TWENTY_ONE(false,"65.0", "21", Versions::checksrc21), | |||
TWENTY_TWO(false,"66.0", "22", Versions::checksrc21); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be checksrc22
instead of checksrc21
? Or is that done later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I have a refactoring of the test planned which will eliminate the explicit "checksrc$N" methods.
/integrate delegate |
@jddarcy Integration of this pull request has been delegated and may be completed by any project committer using the /integrate pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to go :-)
/integrate |
Going to push as commit 5a706fb.
Your commit was automatically rebased without conflicts. |
@JesperIRL Pushed as commit 5a706fb. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Time to get JDK 22 underway...
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13567/head:pull/13567
$ git checkout pull/13567
Update a local copy of the PR:
$ git checkout pull/13567
$ git pull https://git.openjdk.org/jdk.git pull/13567/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13567
View PR using the GUI difftool:
$ git pr show -t 13567
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13567.diff
Webrev
Link to Webrev Comment