8308746: C2 IR test failures for TestFpMinMaxReductions.java with SSE2

[robcasloz]

TestFpMinMaxReductions.java requires UseAVX > 0 to enforce that floating-point min/max computations are matched by specialized implementations in x64 (see x86.ad). This changeset guards the test file with an avx.* CPU feature instead, which is more robust because it reflects the final AVX configuration after all flags are processed (including flags such as UseSSE that might affect the final AVX configuration).

Testing

• TestFpMinMaxReductions.java in tier1-5 (windows-x64, linux-x64, and macosx-x64).
• TestFpMinMaxReductions.java with all possible combinations of UseAVX and UseSSE.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8308746: C2 IR test failures for TestFpMinMaxReductions.java with SSE2

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Contributors

• Jatin Bhateja <jbhateja@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14141/head:pull/14141
$ git checkout pull/14141

Update a local copy of the PR:
$ git checkout pull/14141
$ git pull https://git.openjdk.org/jdk.git pull/14141/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14141

View PR using the GUI difftool:
$ git pr show -t 14141

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14141.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rcastanedalo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[robcasloz]

/contributor add @jatin-bhateja

[openjdk]

@robcasloz
Contributor Jatin Bhateja <jbhateja@openjdk.org> successfully added.

[openjdk]

@robcasloz The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9cae51ca)

[chhagedorn]

Looks good and trivial!

[TobiHartmann]

Looks good and trivial.

[TobiHartmann]

@chhagedorn We seem to be well-synced this week :)

[openjdk]

@robcasloz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308746: C2 IR test failures for TestFpMinMaxReductions.java with SSE2

Co-authored-by: Jatin Bhateja <jbhateja@openjdk.org>
Reviewed-by: chagedorn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• 4f096eb: 8305635: Replace Parse Predicate IfNode with new ParsePredicateNode and route predicate queries through dedicated classes
• f27bc59: 8307132: Cleanup the code of sun.java2d.cmm.lcms package
• 426ebf4: 8308475: Make the thread dump files generated by jcmd Thread.dump_to_file jtreg failure handler action easily accessible
• 8d8153e: 8307958: Metaspace verification is slow causing extreme class unloading times
• d877134: 8144891: ToolBox should use java.nio.file.Path internally, instead of java.io.File
• aaa6189: 8308506: Reduce testing time by removing combinations tested
• 4500bb7: 8308727: Compiler should accept final unnamed variables in try-with-resources
• 3272e25: 8305710: Line breaks in search tags cause invalid JSON in index file
• 3f4abff: 8305958: Use links instead of buttons for auto-generated header links
• bfcae68: 8308549: Classfile API should fail to generate over-sized Code attribute
• ... and 5 more: https://git.openjdk.org/jdk/compare/b44fa365cacce0ae3f9e576a52c08d9ed6258185...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[chhagedorn]

@TobiHartmann Haha, yes indeed! :-)

[robcasloz]

Thanks for the fast reviews Christian and Tobias!

[robcasloz]

/integrate

[openjdk]

Going to push as commit 5a0a238.
Since your change was applied there have been 16 commits pushed to the master branch:

• 38367d3: 8308735: Typos in parameter names
• 4f096eb: 8305635: Replace Parse Predicate IfNode with new ParsePredicateNode and route predicate queries through dedicated classes
• f27bc59: 8307132: Cleanup the code of sun.java2d.cmm.lcms package
• 426ebf4: 8308475: Make the thread dump files generated by jcmd Thread.dump_to_file jtreg failure handler action easily accessible
• 8d8153e: 8307958: Metaspace verification is slow causing extreme class unloading times
• d877134: 8144891: ToolBox should use java.nio.file.Path internally, instead of java.io.File
• aaa6189: 8308506: Reduce testing time by removing combinations tested
• 4500bb7: 8308727: Compiler should accept final unnamed variables in try-with-resources
• 3272e25: 8305710: Line breaks in search tags cause invalid JSON in index file
• 3f4abff: 8305958: Use links instead of buttons for auto-generated header links
• ... and 6 more: https://git.openjdk.org/jdk/compare/b44fa365cacce0ae3f9e576a52c08d9ed6258185...master

Your commit was automatically rebased without conflicts.

[openjdk]

@robcasloz Pushed as commit 5a0a238.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.