6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() #15325

prsadhuk · 2023-08-17T08:42:13Z

javadoc contract for JComponent.setMinimumSize(Dimension) states:

"Sets the minimum size of this component to a constant value. Subsequent calls to getMinimumSize will always return this value..."

However, JScrollBar overrides getMinimumSize() and breaks this contract - it always returns a minimum size derived from the preferred size even if you have previously called setMinimumSize()

Fix is made to check if mnimumSize is set and if so, honour it..

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
Change requires CSR request JDK-8317857 to be approved

Issues

JDK-6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() (Bug - P4)
JDK-8317857: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() (CSR)

Reviewers

Abhishek Kumar (@kumarabhi006 - Committer) ⚠️ Review applies to be0a339b
Phil Race (@prrace - Reviewer) ⚠️ Review applies to 2a42f5c5

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15325/head:pull/15325
$ git checkout pull/15325

Update a local copy of the PR:
$ git checkout pull/15325
$ git pull https://git.openjdk.org/jdk.git pull/15325/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15325

View PR using the GUI difftool:
$ git pr show -t 15325

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15325.diff

Webrev

Link to Webrev Comment

This reverts commit d52de28.

merge

…onent.setMinimumSize()

bridgekeeper · 2023-08-17T08:43:30Z

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-08-17T08:44:34Z

⚠️ @prsadhuk This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

openjdk · 2023-08-17T08:45:01Z

@prsadhuk The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-08-17T08:48:44Z

Webrevs

aivanov-jdk

Looks good to me.

Could you update the copyright year in JScrollBar.java?

test/jdk/javax/swing/JScrollBar/JScrollBarMinSizeTest.java

openjdk · 2023-08-17T15:25:12Z

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize()

Reviewed-by: abhiscxk, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 180 new commits pushed to the master branch:

c266800: 8325558: Add jcheck whitespace checking for properties files
ec20b0a: 8325626: Allow selection of non-matching configurations using CONF=!string
618af39: 8325633: Use stricter assertion in callers of Space::is_aligned
5dbf137: 8319797: Recursive lightweight locking: Runtime implementation
4513da9: 8325470: [AIX] use fclose after fopen in read_psinfo
62a4be0: 8325635: Serial: Inline verify_used_region_at_save_marks
b356fee: 8325458: Rename mlvmJvmtiUtils.h
2ed889b: 8323628: Update license on "pass-through" files
7c69712: 8325570: Update to Graphviz 9.0.0
482c100: 8322865: JavaDoc fails on aggregator modules
... and 170 more: https://git.openjdk.org/jdk/compare/3066d49cc1910bb9ed01558582fdeb2385c484c3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

mrserb · 2023-08-17T19:05:19Z

It looks like the same bug exists in the implementation of getMaximumSize(). BTW the GA are all read, I guess most of that issues were fixed since June 12. Please merge from master.

kumarabhi006

Test verified.

aivanov-jdk

The comment is below…

aivanov-jdk

JScrollBar overrides both getMinimumSize and getMaximumSize and specifies different behaviour: “The scrollbar is flexible along it's scrolling axis and rigid along the other axis.”

Should it follow the rules set by JComponent? It don't think so.

How does the scrollbar look like if you set its minimum or maximum size to a larger size along its other axis?

Should we rather update the spec for JScrollBar? It may override setMinimumSize and setMaximumSize to specify different behaviour.

prsadhuk · 2023-08-28T08:51:56Z

How does the scrollbar look like if you set its minimum or maximum size to a larger size along its other axis?

I dont see any difference in scrollbar look if I set minimum and maximum size to larger size....
for example, this is the screenshot for open/test/jdk/javax/swing/JScrollBar/8039464/Test8039464.java
where I additionally set JScrollBar setMinimumSize to 275,0 and setMaximumSize to 800, 0

but getMinimumSize/getMaximumSize returns 275 and 800..

bridgekeeper · 2023-09-25T11:22:21Z

@prsadhuk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

prsadhuk · 2023-09-27T04:51:23Z

I dont see any visual change with this fix and it solves get/setMinimumSize contract.
However,
I think the suggestion is to update the javadoc for JScrollBar but it does not have setMinimumSize/setMaximumSize method which has the contract in JComponent.setMinimumSize/setMaximumSize
" Subsequent calls to getMaximumSize will always return this value;"

so not sure where to update the spec..in the JScrollBar class top summary or in getMinimumSize/getMaximumSize but since the contract is in set method, not sure if it will be considered if updated in get methods..

@aivanov-jdk @prrace Please provide your opinion..

prrace · 2023-10-10T22:19:51Z

src/java.desktop/share/classes/javax/swing/JScrollBar.java

@@ -760,6 +760,9 @@ public void stateChanged(ChangeEvent e)   {
     * rigid along the other axis.
     */
    public Dimension getMinimumSize() {
+        if (isMinimumSizeSet()) {
+            return super.getMinimumSize();
+        }


This looks like it has potential to cause many compatibility problems.
I think it better to simply update the Jscrollbar spec on these methods to reflect what JScrollbar does.

OK. Fair enough...Updated the spec of getMinimumSize and getMaximumSize to mention this behaviour change as JScrollBar doesn't override setMinimumSize and setMaximumSize

CSR added https://bugs.openjdk.org/browse/JDK-8317857

aivanov-jdk

I admit I'm lost…

Do we implement the hybrid approach? That is getMinimumSize and getMaximumSize return a value derived from getPreferredSize (modifying it so that the scroll bar is flexible along its scrolling axis rather than returning it directly as ComponentUI does). If minimum or maximum size is set, the set value is returned.

Is it correct?

If it is, do we even need to override setMinimumSize and setMaximumSize?

The contract specified in JComponent is satisfied. Yet, not in full: neither of these methods returns ui.get*Size(), either method calls getPreferredSize (which in its turn calls ui.getPreferredSize) and adjusts the value.

Hence, we still need to override them to update get min/max size to say the value is derived from preferred size rather than ui delegate's min/max size. (This can be asserted with a unit test.)

aivanov-jdk · 2024-01-22T18:48:36Z

src/java.desktop/share/classes/javax/swing/JScrollBar.java

+     * @return the value of the {@code minimumSize} property if set by user
+     *         or if not set, minimum size derived from
+     *         preferred size in one axis and fixed size in another axis


I think you should refer the derived size first is the most common returned value, and then mention minimumSize if it's set.

aivanov-jdk · 2024-01-22T19:14:39Z

src/java.desktop/share/classes/javax/swing/JScrollBar.java

+     * Unlike most components, JScrollBar will derive the minimum size from
+     * the preferred size in one axis and a fixed minimum size in the other
+     * unless otherwise set by the user.
+     * Thus, it overrides {@code JComponent.setMinimumSize} contract
+     * that subsequent calls to getMinimumSize will return the
+     * same value as set in {@code JComponent.setMinimumSize}


Doesn't the javadoc contradict the implementation?

This fix has restored the contract of setMinimumSize / getMinimumSize, so JScrollBar is now like other components.

What we can add though is how the size is calculated when it's not set, however, it's documented in the get- methods.

aivanov-jdk · 2024-01-22T19:26:46Z

src/java.desktop/share/classes/javax/swing/JScrollBar.java

+     */
+    public void setMaximumSize(Dimension maximumSize) {
+        super.setMaximumSize(maximumSize);
+    }

    /**
     * The scrollbar is flexible along it's scrolling axis and


Suggested change

* The scrollbar is flexible along it's scrolling axis and

* The scrollbar is flexible along its scrolling axis and

Let's fix it too.

aivanov-jdk · 2024-01-22T19:27:06Z

src/java.desktop/share/classes/javax/swing/JScrollBar.java

@@ -771,8 +804,15 @@ public Dimension getMinimumSize() {
    /**
     * The scrollbar is flexible along it's scrolling axis and


Suggested change

* The scrollbar is flexible along it's scrolling axis and

* The scrollbar is flexible along its scrolling axis and

Yes, I just noticed that too. Pre-existing but clearly not correct grammar.

prrace · 2024-01-22T20:26:00Z

src/java.desktop/share/classes/javax/swing/JScrollBar.java

@@ -771,8 +804,15 @@ public Dimension getMinimumSize() {
    /**
     * The scrollbar is flexible along it's scrolling axis and


Yes, I just noticed that too. Pre-existing but clearly not correct grammar.

prrace · 2024-01-22T21:03:10Z

src/java.desktop/share/classes/javax/swing/JScrollBar.java


    /**
     * The scrollbar is flexible along it's scrolling axis and
     * rigid along the other axis.
+     *
+     * @return the value of the {@code minimumSize} property if set by user
+     *         or if not set, minimum size derived from


Seems we are not there yet. What is in this PR now is internally inconsistent.
It adopts doc on setSize that reads as if getSize will always ignore the super-class contract,
but on the get*Size methods we have new doc and implementation that actually in large part honours it.
One of these needs to change and then the CSR needs to match.

So, revisiting old ground, ie we've been back and forth on this.
we can keep the current PR code which is "if the user calls set*Size, then honour it, accepting the low risk, OR
we can keep the long standing behaviour, which is as near as we can get to no risk.

I'm still a bit on the fence, but I think I never want to hear about JScrollBar size again, :-)
So can we delete the new code in the getSize methods and copy some of the wording from set
*JScrollBar will derive the maximum size from
* the preferred size in one axis and a fixed maximum size in the other

then the return doc can reduce to
@ return the minimum size calculated as described above.

So can we delete the new code in the get_Size methods and copy some of the wording from set_ *JScrollBar will derive the maximum size from * the preferred size in one axis and a fixed maximum size in the other

then the return doc can reduce to @ return the minimum size calculated as described above.

Updated as per suggestion..

prrace · 2024-01-22T21:03:49Z

src/java.desktop/share/classes/javax/swing/JScrollBar.java

+    /**
+     * Unlike most components, JScrollBar will derive the maximum size from
+     * the preferred size in one axis and a fixed maximum size in the other
+     * unless otherwise set by the user.


that last line (unless ...) needs to go if we adopt what I suggest below

prrace

I've also reviewed the CSR. I think that can be finalized but Joe may yet ask us to add some more info in the JComponent methods.

aivanov-jdk · 2024-01-24T14:24:24Z

src/java.desktop/share/classes/javax/swing/JScrollBar.java

+     * Unlike most components, JScrollBar will derive the minimum size from
+     * the preferred size in one axis and a fixed minimum size in the other.
+     * Thus, it overrides {@code JComponent.setMinimumSize} contract
+     * that subsequent calls to getMinimumSize will return the
+     * same value as set in {@code JComponent.setMinimumSize}


Suggested change

* Unlike most components, JScrollBar will derive the minimum size from

* the preferred size in one axis and a fixed minimum size in the other.

* Thus, it overrides {@code JComponent.setMinimumSize} contract

* that subsequent calls to getMinimumSize will return the

* same value as set in {@code JComponent.setMinimumSize}

* Unlike most components, {@code JScrollBar} derives the minimum size from

* the preferred size in one axis and a fixed minimum size in the other.

* Thus, it overrides {@code JComponent.setMinimumSize} contract

* that subsequent calls to {@code getMinimumSize} will return the

* same value as set in {@code JComponent.setMinimumSize}.

@prrace Should the first sentence use the present tense instead of the future?

There should be a period in the end of the sentence.

Should we add a paragraph saying, calling setMinimumSize has no effect?

aivanov-jdk · 2024-01-24T14:35:00Z

src/java.desktop/share/classes/javax/swing/JScrollBar.java

+     * The scrollbar is flexible along its scrolling axis and
     * rigid along the other axis.
+     * As specified in {@code setMinimumSize} JScrollBar will derive the
+     * minimum size from the preferred size in one axis and a
+     * fixed minimum size in the other.
+     *
+     * @return the minimum size as specified above.


The first sentence of the javadoc is put into the method summary, therefore the first sentence should explain what is returned. Is it worth addressing it too?

Something like: Returns the minimum size for the {@code JScrollBar}. The minimum size is equal to a fixed minimum value along its scrolling axis and the preferred size along the other axis.

aivanov-jdk · 2024-01-24T14:40:49Z

src/java.desktop/share/classes/javax/swing/JScrollBar.java

+     * The scrollbar is flexible along its scrolling axis and
     * rigid along the other axis.
+     * As specified in {@code setMaximumSize} JScrollBar will derive the
+     * maximum size from the preferred size in one axis and a
+     * fixed maximum size in the other.
+     *
+     * @return the maximum size as specified above.


This can be amended in a similar way to getMinimumSize.

Returns the maximum size for the {@code JScrollBar}. The maximum size is equal to a fixed maximum value its scrolling axis and the preferred size along the other axis. This makes the scrollbar flexible along its scrolling axis and rigid along the other axis.

prsadhuk · 2024-01-29T06:44:03Z

Added JComponent clarification to address CSR concern..

aivanov-jdk · 2024-01-29T09:57:43Z

src/java.desktop/share/classes/javax/swing/JComponent.java

+     * to compute it.
+     * Subclasses may choose to override this by returning its own maximum size
+     * in its {@code getMaximumSize} method.
+     * Setting the maximum size to <code>null</code> restores the default behavior.


I'd leave null-related where it was because it belongs to the description of the default behaviour. And subclasses can override the default behaviour.

Suggested change

* to compute it.

* Subclasses may choose to override this by returning its own maximum size

* in its {@code getMaximumSize} method.

* Setting the maximum size to <code>null</code> restores the default behavior.

* to compute it. Setting the maximum size to <code>null</code>

* restores the default behavior.

* <p>

* Subclasses may choose to override this by returning its own maximum size

* in its {@code getMaximumSize} method.

Add <p> to start a new paragraph in the javadoc so that the statement is easier to notice.

I suggest to keep one style, either use <code> or {@code} everywhere. Using different styles doesn't look good.

Since the modern way is to use {@code}, it makes sense to update the entire method doc. Yet it will make it harder to find the important changes.

src/java.desktop/share/classes/javax/swing/JScrollBar.java

src/java.desktop/share/classes/javax/swing/JComponent.java

aivanov-jdk · 2024-01-29T10:02:55Z

src/java.desktop/share/classes/javax/swing/JScrollBar.java

@@ -780,6 +780,7 @@ public void setMaximumSize(Dimension maximumSize) {
    }

    /**
+     * Returns the minimum size for the {@code JScrollBar}.
     * The scrollbar is flexible along its scrolling axis and
     * rigid along the other axis.
     * As specified in {@code setMinimumSize} JScrollBar will derive the


This doesn't look good to me. It is getMinimumSize that specifies what is returned; setMinimumSize just warns the programmer that getMinimumSize ignores the value passed to the set- method.

It's the other way around: getMinimumSize should specify and specifies what it returns — setMinimumSize is being updated to align with the implementation of the get-.

aivanov-jdk · 2024-01-29T10:07:35Z

src/java.desktop/share/classes/javax/swing/JScrollBar.java

+     * The scrollbar is flexible along its scrolling axis and
     * rigid along the other axis.


I would rather clarify this property by describing how the returned value is derived from the preferred size. Does it make sense? Should it be an @implNote rather than a spec? Or is it completely unnecessary?

Not sure..Since it is already reviewed and approved by Phil, I chose to keep it same..

This change requires a CSR which hasn't been approved yet. It's an opportunity to improve the specification for getMinimumSize and getMaximumSize.

After the CSR is approved, further updates will be more of a hassle.

This is why I'm asking these questions here. “No, we don't want to update,” is also a valid answer. Let's see what @prrace has to say.

openjdk · 2024-01-29T10:17:07Z

@prsadhuk this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-6510914
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

aivanov-jdk · 2024-01-29T11:16:11Z

src/java.desktop/share/classes/javax/swing/JComponent.java

+     * Subclasses may choose to override this by returning its own maximum size
+     * in its {@code getMaximumSize} method.


Suggested change

* Subclasses may choose to override this by returning its own maximum size

* in its {@code getMaximumSize} method.

* Subclasses may choose to override this by returning their own maximum size

* in the {@code getMaximumSize} method.

“Subclasses” is plural and therefore requires plural possessive pronoun.

aivanov-jdk · 2024-01-29T11:16:45Z

src/java.desktop/share/classes/javax/swing/JComponent.java

+     * Subclasses may choose to override this by returning its own minimum size
+     * in its {@code getMinimumSize} method.


Suggested change

* Subclasses may choose to override this by returning its own minimum size

* in its {@code getMinimumSize} method.

* Subclasses may choose to override this by returning their own minimum size

* in the {@code getMinimumSize} method.

aivanov-jdk · 2024-01-29T11:22:56Z

src/java.desktop/share/classes/javax/swing/JScrollBar.java

+     * The scrollbar is flexible along its scrolling axis and
     * rigid along the other axis.


This change requires a CSR which hasn't been approved yet. It's an opportunity to improve the specification for getMinimumSize and getMaximumSize.

After the CSR is approved, further updates will be more of a hassle.

This is why I'm asking these questions here. “No, we don't want to update,” is also a valid answer. Let's see what @prrace has to say.

aivanov-jdk · 2024-01-29T11:28:16Z

src/java.desktop/share/classes/javax/swing/JScrollBar.java

+     * minimum size from the preferred size in one axis and a
+     * fixed minimum size in the other.
+     *
+     * @return the minimum size as specified above.


Suggested change

* @return the minimum size as specified above.

* @return the minimum size as specified above

@return tags usually don't have a period in the end. Let's follow it for consistency.

prsadhuk · 2024-02-18T16:13:26Z

/integrate

openjdk · 2024-02-18T16:14:34Z

Going to push as commit 39627bc.
Since your change was applied there have been 249 commits pushed to the master branch:

7004c27: 8303972: (zipfs) Make test/jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java independent of the zip command line
c2d9fa2: 8326000: Remove obsolete comments for class sun.security.ssl.SunJSSE
f50df10: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently
cf13086: 8317697: refactor-encapsulate x86 VM_Version::CpuidInfo
3b76372: 8325687: SimpleJavaFileObject specification would benefit from implSpec
b5df2f4: 8323170: j2dbench is using outdated javac source/target to be able to build by itself
267780b: 8324680: Replace NULL with nullptr in JVMTI generated code
f3073db: 8321408: Add Certainly roots R1 and E1
4c7b313: 8325908: Finish removal of IntlTest and CollatorTest
5310250: 8325941: Remove unused Space::block_size
... and 239 more: https://git.openjdk.org/jdk/compare/3066d49cc1910bb9ed01558582fdeb2385c484c3...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-02-18T16:14:40Z

@prsadhuk Pushed as commit 39627bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

prsadhuk added 6 commits June 9, 2023 06:14

Fix

d52de28

Revert "Fix"

f3a9171

This reverts commit d52de28.

Merge remote-tracking branch 'upstream/master'

197f2f0

merge

Merge remote-tracking branch 'upstream/master'

58d01e0

Merge branch 'master' of github.com:prsadhuk/jdk

0b86026

JDK-6510914: JScrollBar.getMinimumSize() breaks the contract of JComp…

31bbdee

…onent.setMinimumSize()

openjdk bot added the rfr Pull request is ready for review label Aug 17, 2023

openjdk bot added the client client-libs-dev@openjdk.org label Aug 17, 2023

aivanov-jdk approved these changes Aug 17, 2023

View reviewed changes

test/jdk/javax/swing/JScrollBar/JScrollBarMinSizeTest.java Outdated Show resolved Hide resolved

openjdk bot added the ready Pull request is ready to be integrated label Aug 17, 2023

prsadhuk added 2 commits August 24, 2023 08:38

Fix maximumSize, test

d152b88

copyright year

be0a339

kumarabhi006 approved these changes Aug 24, 2023

View reviewed changes

aivanov-jdk reviewed Aug 24, 2023

View reviewed changes

aivanov-jdk suggested changes Aug 24, 2023

View reviewed changes

openjdk bot removed the ready Pull request is ready to be integrated label Aug 24, 2023

prrace reviewed Oct 10, 2023

View reviewed changes

Update spec

9b96c33

openjdk bot added the csr Pull request needs approved CSR before integration label Oct 11, 2023

prsadhuk added 2 commits October 19, 2023 09:30

Spec update

09b8b82

Remove unneeded methods

6a9a1d5

aivanov-jdk reviewed Jan 22, 2024

View reviewed changes

prrace suggested changes Jan 22, 2024

View reviewed changes

PR update as per review

c651106

openjdk bot removed the rfr Pull request is ready for review label Jan 23, 2024

PR update as per review

2a42f5c

openjdk bot added the rfr Pull request is ready for review label Jan 23, 2024

prrace approved these changes Jan 23, 2024

View reviewed changes

aivanov-jdk suggested changes Jan 24, 2024

View reviewed changes

javadoc update in JScrollbar and JComponent

10b670c

aivanov-jdk suggested changes Jan 29, 2024

View reviewed changes

javadoc change

66a50bc

openjdk bot added merge-conflict Pull request has merge conflict with target branch and removed rfr Pull request is ready for review labels Jan 29, 2024

Merge master

1d8fff4

openjdk bot added rfr Pull request is ready for review and removed merge-conflict Pull request has merge conflict with target branch labels Jan 29, 2024

aivanov-jdk suggested changes Jan 29, 2024

View reviewed changes

review update

4937fcc

openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Feb 1, 2024

openjdk bot added the integrated Pull request has been integrated label Feb 18, 2024

openjdk bot closed this Feb 18, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 18, 2024

prsadhuk deleted the JDK-6510914 branch February 18, 2024 16:15

	* The scrollbar is flexible along it's scrolling axis and
	* The scrollbar is flexible along its scrolling axis and

		@@ -771,8 +804,15 @@ public Dimension getMinimumSize() {
		/**
		* The scrollbar is flexible along it's scrolling axis and

		* The scrollbar is flexible along its scrolling axis and
		* rigid along the other axis.

		* Subclasses may choose to override this by returning its own maximum size
		* in its {@code getMaximumSize} method.

		* Subclasses may choose to override this by returning its own minimum size
		* in its {@code getMinimumSize} method.

	* @return the minimum size as specified above.
	* @return the minimum size as specified above

6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() #15325

6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() #15325

Conversation

prsadhuk commented Aug 17, 2023 • edited by openjdk bot Loading

Progress

Issues

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Aug 17, 2023

openjdk bot commented Aug 17, 2023

openjdk bot commented Aug 17, 2023

mlbridge bot commented Aug 17, 2023 • edited Loading

Webrevs

aivanov-jdk left a comment

Choose a reason for hiding this comment

openjdk bot commented Aug 17, 2023 • edited Loading

mrserb commented Aug 17, 2023

kumarabhi006 left a comment

Choose a reason for hiding this comment

aivanov-jdk left a comment • edited Loading

Choose a reason for hiding this comment

aivanov-jdk left a comment

Choose a reason for hiding this comment

prsadhuk commented Aug 28, 2023

bridgekeeper bot commented Sep 25, 2023

prsadhuk commented Sep 27, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aivanov-jdk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prrace left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prsadhuk commented Jan 29, 2024

Choose a reason for hiding this comment

aivanov-jdk Jan 29, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openjdk bot commented Jan 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prsadhuk commented Feb 18, 2024

openjdk bot commented Feb 18, 2024

openjdk bot commented Feb 18, 2024

prsadhuk commented Aug 17, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Aug 17, 2023 •

edited

Loading

openjdk bot commented Aug 17, 2023 •

edited

Loading

aivanov-jdk left a comment •

edited

Loading

aivanov-jdk Jan 29, 2024 •

edited

Loading