8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler

[magicus]

This is a retake on #15096.

I tried to fix the remaining issues in that PR, but could not push them. In the end, it seemed easier to create a new branch in my own personal fork.

The majority of the work in this PR has been done by @TheShermanTanker. I have stepped in and fixed the remaining comments, reverted some additional unneeded changed code, and also tried to minimize code duplication in awt_PrintJob.cpp.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler (Enhancement - P4)

Reviewers

• Julian Waters (@TheShermanTanker - Committer)
• Phil Race (@prrace - Reviewer)

Contributors

• Magnus Ihse Bursie <ihse@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18584/head:pull/18584
$ git checkout pull/18584

Update a local copy of the PR:
$ git checkout pull/18584
$ git pull https://git.openjdk.org/jdk.git pull/18584/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18584

View PR using the GUI difftool:
$ git pr show -t 18584

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18584.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler

Co-authored-by: Magnus Ihse Bursie <ihse@openjdk.org>
Reviewed-by: jwaters, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@magicus The following labels will be automatically applied to this pull request:

• build
• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[magicus]

/author set @TheShermanTanker
/contributor add ihse

[openjdk]

@magicus
Setting overriding author to Julian Waters <jwaters@openjdk.org>. When this pull request is integrated, the overriding author will be used in the commit.

[openjdk]

@magicus
Contributor Magnus Ihse Bursie <ihse@openjdk.org> successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (868dc56d)
• 00: Full (e9780f0c)

[TheShermanTanker]

Looks good. Thanks for taking this up for me! In the future I hope @prrace will change his mind and allow the use of C++ Libraries in awt (awt already depends on the C++ Standard Library on Windows, verifiable if you run dumpbin -DEPENDENTS on it), because I have a change in mind relying on RAII that would look much cleaner and neater

[magicus]

/integrate

[openjdk]

Going to push as commit 8bc1867.
Since your change was applied there have been 11 commits pushed to the master branch:

• 8efe569: 8328747: WrongMethodTypeException with pattern matching on switch on sealed classes
• 71d48bc: 8329655: Cleanup KlassObj and klassOop names after the PermGen removal
• b71acc7: 8329089: Empty immutable list throws the wrong exception type for remove(first | last) operations
• 1131bb7: 8329261: G1: interpreter post-barrier x86 code asserts index size of wrong buffer
• 6bc6392: 8329201: C2: Replace TypeInterfaces::intersection_with() + eq() with contains()
• 9da5170: 8327978: C2 SuperWord: Fix compilation time regression in dependency graph traversal after JDK-8325651
• c1cfb43: 8329109: Threads::print_on() tries to print CPU time for terminated GC threads
• 5860a48: 8329624: Add visitors for preview language features
• 0b01144: 8329720: Gtest failure printing markword after JDK-8325303
• 34f7974: 8325303: Replace markWord.is_neutral() with markWord.is_unlocked()
• ... and 1 more: https://git.openjdk.org/jdk/compare/e1183ac044f803bf0d4ccfebc2b1cd5b33294c7a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@magicus Pushed as commit 8bc1867.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.