8266796: Clean up the unnecessary code in the method UnsharedNameTable#fromUtf

[lgxbslgx]

Hi all,

This little patch cleans up the redundant code. Please see the code below.

        while (element != null) {
            if (element == null) {
                break;
            }

The while (element != null) has already checked the element. So the if (element == null) is redundant and unnecessary.

Thank you for taking the time to review.

Best Regards,
-- Guoxiong

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8266796: Clean up the unnecessary code in the method UnsharedNameTable#fromUtf

Reviewers

• Maurizio Cimadamore (@mcimadamore - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3942/head:pull/3942
$ git checkout pull/3942

Update a local copy of the PR:
$ git checkout pull/3942
$ git pull https://git.openjdk.java.net/jdk pull/3942/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3942

View PR using the GUI difftool:
$ git pr show -t 3942

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3942.diff

[bridgekeeper]

👋 Welcome back gli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lgxbslgx The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (442687ac)

[mcimadamore]

Looks good

[openjdk]

@lgxbslgx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266796: Clean up the unnecessary code in the method UnsharedNameTable#fromUtf

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• e41fd73: 8266252: Streamline AbstractInterpreter::method_kind
• b823b3e: 8266797: Fix for 8266610 breaks the build on macos
• 53db2a0: 8226384: Implement a better logic to switch between OpenGL and Metal pipeline
• 1603ca2: 8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)
• 0f925d1: 8266015: Implement AdapterHandlerLibrary lookup fast-path for common adapters
• 69b96f9: 8266610: Method RandomAccessFile#length() returns 0 for block devices on linux.
• 9b76955: 8266249: javax/swing/JPopupMenu/7156657/bug7156657.java fails on macOS

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mcimadamore) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[lgxbslgx]

@mcimadamore Thanks for your review. Could I get your help to sponsor this patch?

/integrate

[openjdk]

@lgxbslgx
Your change (at version 442687a) is now ready to be sponsored by a Committer.

[mcimadamore]

/sponsor

[openjdk]

@mcimadamore @lgxbslgx Since your change was applied there have been 7 commits pushed to the master branch:

• e41fd73: 8266252: Streamline AbstractInterpreter::method_kind
• b823b3e: 8266797: Fix for 8266610 breaks the build on macos
• 53db2a0: 8226384: Implement a better logic to switch between OpenGL and Metal pipeline
• 1603ca2: 8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)
• 0f925d1: 8266015: Implement AdapterHandlerLibrary lookup fast-path for common adapters
• 69b96f9: 8266610: Method RandomAccessFile#length() returns 0 for block devices on linux.
• 9b76955: 8266249: javax/swing/JPopupMenu/7156657/bug7156657.java fails on macOS

Your commit was automatically rebased without conflicts.

Pushed as commit 5d761fc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.