Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267465: remove superfluous preview related annotations and test options #4330

Closed

Conversation

vicente-romero-oracle
Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle commented Jun 3, 2021

Please review this PR which is removing several superfluous @SuppressWarnings("preview") annotations from the compiler code and also removing preview related, but not needed anymore, options from regression tests.

TIA


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267465: remove superfluous preview related annotations and test options

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4330/head:pull/4330
$ git checkout pull/4330

Update a local copy of the PR:
$ git checkout pull/4330
$ git pull https://git.openjdk.java.net/jdk pull/4330/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4330

View PR using the GUI difftool:
$ git pr show -t 4330

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4330.diff

@vicente-romero-oracle
Copy link
Contributor Author

/csr

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 3, 2021

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review csr Pull request needs approved CSR before integration labels Jun 3, 2021
@openjdk
Copy link

openjdk bot commented Jun 3, 2021

@vicente-romero-oracle this pull request will not be integrated until the CSR request JDK-8268143 for issue JDK-8267465 has been approved.

@openjdk
Copy link

openjdk bot commented Jun 3, 2021

@vicente-romero-oracle The following labels will be automatically applied to this pull request:

  • compiler
  • kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added compiler compiler-dev@openjdk.org kulla kulla-dev@openjdk.org labels Jun 3, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 3, 2021

Webrevs

@vicente-romero-oracle
Copy link
Contributor Author

/label remove csr

@openjdk
Copy link

openjdk bot commented Jun 4, 2021

@vicente-romero-oracle The label csr is not a valid label. These labels are valid:

  • serviceability
  • hotspot
  • sound
  • hotspot-compiler
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • 2d
  • security
  • swing
  • hotspot-runtime
  • jmx
  • build
  • nio
  • beans
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr
  • awt

@vicente-romero-oracle
Copy link
Contributor Author

/test

@vicente-romero-oracle
Copy link
Contributor Author

/csr unneeded

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Jun 4, 2021
@openjdk
Copy link

openjdk bot commented Jun 4, 2021

Could not create test job

@openjdk
Copy link

openjdk bot commented Jun 4, 2021

@vicente-romero-oracle determined that a CSR request is not needed for this pull request.

Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. I would like to ask to wait with integration of this until: #3863 is integrated, in case there would be some conflict. Thanks!

@openjdk
Copy link

openjdk bot commented Jun 6, 2021

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267465: remove superfluous preview related annotations and test options

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

  • 52d88ee: 8268292: compiler/intrinsics/VectorizedMismatchTest.java fails with release VMs
  • 042f0bd: 8256465: [macos] Java frame and dialog presented full screen freeze application
  • 8abf36c: 8268289: build failure due to missing signed flag in x86 evcmpb instruction
  • b05c40c: 8266951: Partial in-lining for vectorized mismatch operation using AVX512 masked instructions
  • f768fbf: 8268286: ProblemList serviceability/sa/TestJmapCore.java on linux-aarch64 with ZGC
  • b2e9eb9: 8268087: Update documentation of the JPasswordField
  • 91f9adc: 8268139: CDS ArchiveBuilder may reference unloaded classes
  • 36bff6f: 8066694: Strange code in JavacParser.java
  • 6c838c5: 8266846: Add java.time.InstantSource
  • 7f55dc1: 8179880: Refactor javax/security shell tests to plain java tests
  • ... and 26 more: https://git.openjdk.java.net/jdk/compare/5405f983db7d359bb65c42366541104c5e9ef7c3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 6, 2021
@vicente-romero-oracle
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Jun 7, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 7, 2021
@openjdk
Copy link

openjdk bot commented Jun 7, 2021

@vicente-romero-oracle Since your change was applied there have been 51 commits pushed to the master branch:

  • 728a411: 8268018: remove dead code in commitLimitter
  • 15715a8: 8267924: Misleading G1 eager reclaim detail logging
  • e4d0454: 8267832: SimpleVisitors and Scanners in jdk.compiler should use @implSpec
  • 8130be5: 8268318: Missing comma in copyright header
  • b09d8b9: 8267926: AsyncLogGtest.java fails on assert with: decorator was not part of the decorator set specified at creation.
  • 5ebd419: 8267972: Inline cache cleaning is not monotonic
  • 6d1f3ac: 8149138: [javadoc] Fix SerialFormBuilder eliminate String bashing
  • 58bdabc: 8268164: Adopt cast notation for WorkerThread conversions
  • 9fc914b: 8204686: Dynamic parallel reference processing support for Parallel GC
  • 908aca2: 8262891: Compiler implementation for Pattern Matching for switch (Preview)
  • ... and 41 more: https://git.openjdk.java.net/jdk/compare/5405f983db7d359bb65c42366541104c5e9ef7c3...master

Your commit was automatically rebased without conflicts.

Pushed as commit 4f9d6b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated kulla kulla-dev@openjdk.org
2 participants