-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8267465: remove superfluous preview related annotations and test options #4330
8267465: remove superfluous preview related annotations and test options #4330
Conversation
/csr |
👋 Welcome back vromero! A progress list of the required criteria for merging this PR into |
@vicente-romero-oracle this pull request will not be integrated until the CSR request JDK-8268143 for issue JDK-8267465 has been approved. |
@vicente-romero-oracle The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
/label remove csr |
@vicente-romero-oracle The label
|
/test |
/csr unneeded |
Could not create test job |
@vicente-romero-oracle determined that a CSR request is not needed for this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me. I would like to ask to wait with integration of this until: #3863 is integrated, in case there would be some conflict. Thanks!
@vicente-romero-oracle This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 36 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@vicente-romero-oracle Since your change was applied there have been 51 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 4f9d6b7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this PR which is removing several superfluous
@SuppressWarnings("preview")
annotations from the compiler code and also removing preview related, but not needed anymore, options from regression tests.TIA
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4330/head:pull/4330
$ git checkout pull/4330
Update a local copy of the PR:
$ git checkout pull/4330
$ git pull https://git.openjdk.java.net/jdk pull/4330/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4330
View PR using the GUI difftool:
$ git pr show -t 4330
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4330.diff