Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253965: Delete the outdated java.awt.PeerFixer class #493

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Oct 3, 2020

This bug is extracted from the JDK-8251123. Instead of specifying this old/unused class, I suggest to delete it.

This is the comment added to this class in JDK 1.1.1:

==============================
/*

  • In JDK 1.1.1, the pkg private class java.awt.PeerFixer was moved to
  • become an inner class of ScrollPane, which broke serialization
  • for ScrollPane objects using JDK 1.1.
  • Instead of moving it back out here, which would break all JDK 1.1.x
  • releases, we keep PeerFixer in both places. Because of the scoping rules,
  • the PeerFixer that is used in ScrollPane will be the one that is the
  • inner class. This pkg private PeerFixer class below will only be used
  • if the Java 2 platform is used to deserialize ScrollPane objects that were serialized
  • using JDK1.1
    */

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (3/3 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ❌ (1/9 failed) ✔️ (8/8 passed)

Failed test task

Issue

  • JDK-8253965: Delete the outdated java.awt.PeerFixer class

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/493/head:pull/493
$ git checkout pull/493

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@mrserb
Copy link
Member Author

mrserb commented Oct 3, 2020

/csr

@openjdk
Copy link

openjdk bot commented Oct 3, 2020

@mrserb The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added awt client-libs-dev@openjdk.org csr Pull request needs approved CSR before integration labels Oct 3, 2020
@openjdk
Copy link

openjdk bot commented Oct 3, 2020

@mrserb this pull request will not be integrated until the CSR request JDK-8253967 for issue JDK-8253965 has been approved.

@mrserb mrserb marked this pull request as ready for review October 3, 2020 03:57
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 3, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 3, 2020

Webrevs

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Oct 8, 2020
@openjdk
Copy link

openjdk bot commented Oct 8, 2020

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8253965: Delete the outdated java.awt.PeerFixer class

Reviewed-by: prr, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

  • 4e5ef30: 8254104: MethodCounters must exist before nmethod is installed
  • fd0cb98: 8253901: ARM32: SIGSEGV during monitorexit due to incorrect register use (after JDK-8253540)
  • abe2593: 8232092: (fs) Files::isWritable returns false on a writeable root directory (win)
  • 5a9bd41: 8254102: use ProcessHandle::pid instead of ManagementFactory::getRuntimeMXBean to get pid in tests
  • 38159d5: 8253876: jdk/test/lib/hexdump/ASN1FormatterTest.java fails with "AssertionError: Lines expected [126] but found [202]"
  • db3053d: 8067127: Tags cleanup
  • 739347f: 8254168: Remove TemplateTable::count_calls
  • 4fe07cc: 8252324: Signal related code should be shared among POSIX platforms
  • 1e8e543: 8216497: javadoc should auto-link to platform classes
  • 04ca660: 8253874: [JVMCI] added test omitted in 8252881
  • ... and 39 more: https://git.openjdk.java.net/jdk/compare/d296708ca66ab15e31a05f963a5e162a3e3f07f9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 8, 2020
@mrserb
Copy link
Member Author

mrserb commented Oct 9, 2020

/integrate

@openjdk openjdk bot closed this Oct 9, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 9, 2020
@openjdk
Copy link

openjdk bot commented Oct 9, 2020

@mrserb Since your change was applied there have been 70 commits pushed to the master branch:

  • ced46b1: 8254190: [s390] interpreter misses exception check after calling monitorenter
  • 5351ba6: 8254262: jdk.test.lib.Utils::createTemp* don't pass attrs
  • 8c0d3d7: 8254195: java/nio/file/Files/SubstDrive.java failed with "AssertionError: expected [144951656448] but found [144951640064]"
  • c2a5de6: 8253681: closed java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed
  • d036dca: 8254103: Shenandoah: Move updating thread roots to concurrent phase
  • 7e82ba1: 8254146: Avoid unnecessary volatile write on new AtomicBoolean(false)
  • 6d13c76: 8253191: C2: Masked byte comparisons with large masks produce wrong result on x86
  • a191c58: 8253404: C2: assert(C->live_nodes() <= C->max_node_limit()) failed: Live Node limit exceeded limit
  • 6bc4931: 8253717: Relocate stack overflow code out of thread.hpp/cpp
  • 782d45b: 8242882: opening jar file with large manifest might throw NegativeArraySizeException
  • ... and 60 more: https://git.openjdk.java.net/jdk/compare/d296708ca66ab15e31a05f963a5e162a3e3f07f9...master

Your commit was automatically rebased without conflicts.

Pushed as commit 70be8c7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8253965 branch April 12, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awt client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants