Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278609: accessibility frame is misplaced on a secondary monitor on macOS #6815

Conversation

VeselovAlex
Copy link
Contributor

@VeselovAlex VeselovAlex commented Dec 13, 2021

Use primary screen instead of window main screen to properly convert mouse position from screen coordinates to window ones.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8278609

Issue

  • JDK-8278609: [macos] accessibility frame is misplaced on a secondary monitor on macOS ⚠️ Title mismatch between PR and JBS.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6815/head:pull/6815
$ git checkout pull/6815

Update a local copy of the PR:
$ git checkout pull/6815
$ git pull https://git.openjdk.java.net/jdk pull/6815/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6815

View PR using the GUI difftool:
$ git pr show -t 6815

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6815.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Dec 13, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2021

Hi @VeselovAlex, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user VeselovAlex" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Dec 13, 2021

@VeselovAlex The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Dec 13, 2021
@@ -792,7 +792,7 @@ - (NSRect)accessibilityFrame
(*env)->DeleteLocalRef(env, axComponent);
point.y += size.height;

point.y = [[[[self view] window] screen] frame].size.height - point.y;
point.y = [[NSScreen screens][0] frame].size.height - point.y;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't the objectAtIndex is widely used than [] in our code base?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@VeselovAlex
Copy link
Contributor Author

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Dec 14, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2021

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Dec 17, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 17, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 17, 2021

Webrevs

@victordyakov
Copy link

please re-submit against 18 repo

@VeselovAlex
Copy link
Contributor Author

Changes moved to jdk18/48, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org rfr Pull request is ready for review
3 participants