8278609: accessibility frame is misplaced on a secondary monitor on macOS #6815
Conversation
|
Hi @VeselovAlex, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user VeselovAlex" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
@VeselovAlex The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
| @@ -792,7 +792,7 @@ - (NSRect)accessibilityFrame | |||
| (*env)->DeleteLocalRef(env, axComponent); | |||
| point.y += size.height; | |||
|
|
|||
| point.y = [[[[self view] window] screen] frame].size.height - point.y; | |||
| point.y = [[NSScreen screens][0] frame].size.height - point.y; | |||
There was a problem hiding this comment.
isn't the objectAtIndex is widely used than [] in our code base?
|
/covered |
|
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
bridgekeeper
bot
removed
oca
|
please re-submit against 18 repo |
|
Changes moved to jdk18/48, closing |
Use primary screen instead of window main screen to properly convert mouse position from screen coordinates to window ones.
Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6815/head:pull/6815$ git checkout pull/6815Update a local copy of the PR:
$ git checkout pull/6815$ git pull https://git.openjdk.java.net/jdk pull/6815/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6815View PR using the GUI difftool:
$ git pr show -t 6815Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6815.diff