JDK-8289238: Refactoring changes to PassFailJFrame Test Framework

[honkar-jdk]

Currently PassFailJFrame.positionTestFrame() and PassFailJFrame.addTestFrame() take Frame as input parameter, this has been changed to Window.

Refactored the above method names to reflect the functionality & input parameter type -
addTestWindow(), positionTestWindow()

Additionally added test fail reason to forceFail() to avoid NPE.

Benefits of the change -

• Since Window is a parent class, this would allow the test frame to be a Window/Frame/Dialog and not be restricted to a Frame.
• Code reusability - no need to have separate methods to manage Frame and Window
• Additionally it would allow proper clean-up of window and its container subclasses which are added to the PassFailJFrame.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8289238: Refactoring changes to PassFailJFrame Test Framework

Reviewers

• Alexander Zvegintsev (@azvegint - Reviewer)
• Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9300/head:pull/9300
$ git checkout pull/9300

Update a local copy of the PR:
$ git checkout pull/9300
$ git pull https://git.openjdk.org/jdk pull/9300/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9300

View PR using the GUI difftool:
$ git pr show -t 9300

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9300.diff

[bridgekeeper]

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@honkar-jdk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (3539873f)
• 02: Full - Incremental (1270cafa)
• 01: Full - Incremental (30d379ab)
• 00: Full (ef00a014)

[azvegint]

Shouldn't it be windows instead of testWindow, because we can add plenty of them with addTestWindow()?

Otherwise looks good.

[azvegint]

It looks like you accidentally removed the empty line that served as the visual delimiter.

[honkar-jdk]

@azvegint Thanks for catching it. Updated the PR with changes.

[openjdk]

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289238: Refactoring changes to PassFailJFrame Test Framework

Reviewed-by: azvegint, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

• b6bd190: 8288985: P11TlsKeyMaterialGenerator should work with ChaCha20-Poly1305
• ba670ec: 8289094: [JVMCI] reduce JNI overhead and other VM rounds trips in JVMCI
• 0709a6a: 8284942: Proxy building can just iterate superinterfaces once
• 2961b7e: 8285364: Remove REF_ enum for java.lang.ref.Reference
• 167ce4d: 8289421: No-PCH build for Minimal VM was broken by JDK-8287001
• 108cd69: 8283726: x86_64 intrinsics for compareUnsigned method in Integer and Long
• b96ba19: 8289182: NMT: MemTracker::baseline should return void
• 779b4e1: 8287001: Add warning message when fail to load hsdis libraries
• 910053b: 8280235: Deprecated flag FlightRecorder missing from VMDeprecatedOptions test
• 7b3bf97: 8289401: Add dump output to TestRawRSACipher.java
• ... and 30 more: https://git.openjdk.org/jdk/compare/d4b040f42dd0a9100ad1ffa55de4ae4f20e9f182...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@azvegint, @aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[honkar-jdk]

/integrate

[openjdk]

@honkar-jdk
Your change (at version 3539873) is now ready to be sponsored by a Committer.

[aivanov-jdk]

/sponsor

[openjdk]

Going to push as commit 15efb2b.
Since your change was applied there have been 40 commits pushed to the master branch:

• b6bd190: 8288985: P11TlsKeyMaterialGenerator should work with ChaCha20-Poly1305
• ba670ec: 8289094: [JVMCI] reduce JNI overhead and other VM rounds trips in JVMCI
• 0709a6a: 8284942: Proxy building can just iterate superinterfaces once
• 2961b7e: 8285364: Remove REF_ enum for java.lang.ref.Reference
• 167ce4d: 8289421: No-PCH build for Minimal VM was broken by JDK-8287001
• 108cd69: 8283726: x86_64 intrinsics for compareUnsigned method in Integer and Long
• b96ba19: 8289182: NMT: MemTracker::baseline should return void
• 779b4e1: 8287001: Add warning message when fail to load hsdis libraries
• 910053b: 8280235: Deprecated flag FlightRecorder missing from VMDeprecatedOptions test
• 7b3bf97: 8289401: Add dump output to TestRawRSACipher.java
• ... and 30 more: https://git.openjdk.org/jdk/compare/d4b040f42dd0a9100ad1ffa55de4ae4f20e9f182...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aivanov-jdk @honkar-jdk Pushed as commit 15efb2b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.