-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8315415: OutputAnalyzer.shouldMatchByLine() fails in some cases #2505
Conversation
👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
@luchenlin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@luchenlin Pushed as commit 38c11fd. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I backport this for parity with 11.0.23-oracle.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2505/head:pull/2505
$ git checkout pull/2505
Update a local copy of the PR:
$ git checkout pull/2505
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2505/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2505
View PR using the GUI difftool:
$ git pr show -t 2505
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2505.diff
Webrev
Link to Webrev Comment