Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination #2573

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Feb 28, 2024

Backport of JDK-8317287

Testing

  • Local: Test passed
    • InterJVMGetDropSuccessTest.java - Test results: passed: 1
  • Pipeline: All checks have passed
  • Testing Machine: SAP nightlies passed on 2024-03-01,03

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8317287 needs maintainer approval

Issue

  • JDK-8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2573/head:pull/2573
$ git checkout pull/2573

Update a local copy of the PR:
$ git checkout pull/2573
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2573/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2573

View PR using the GUI difftool:
$ git pr show -t 2573

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2573.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2024

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cbfddf4e1d3ff8dddb95bcb9242b31c175b768fc 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination Feb 28, 2024
@openjdk
Copy link

openjdk bot commented Feb 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 28, 2024

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 28, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2024

Webrevs

@amosshi
Copy link
Contributor Author

amosshi commented Mar 7, 2024

/approval request “Backporting for parity with jdk 11.0.24-oracle. Clean backport. Test case only, no risk. SAP nightlies passed on 2024-03-01,03”

@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@amosshi
8317287: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 7, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • 7b7fbdf: 8267938: (sctp) SCTP channel factory methods should check platform support
  • f3069d1: 8325972: Add -x to bash for building with LOG=debug
  • b425dff: 8320303: Allow PassFailJFrame to accept single window creator
  • bc14b9f: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop
  • 4ef8db8: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053
  • 6c0a88d: 8271142: package help is not displayed for missing X11/extensions/Xrandr.h
  • 2a78f2f: Merge
  • 5c5687d: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
  • a4a5c7f: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
  • f6e6eef: 8326938: [11u] JDK-8214908 broke two CTW tests
  • ... and 12 more: https://git.openjdk.org/jdk11u-dev/compare/1bb3ed339b50b7cc60279bb51c36d8e449453d4e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 11, 2024
@amosshi
Copy link
Contributor Author

amosshi commented Mar 11, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 11, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@amosshi
Your change (at version f3bc8d3) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 11, 2024

Going to push as commit 9b40856.
Since your change was applied there have been 24 commits pushed to the master branch:

  • fbac37b: 8307083: Open source some drag and drop tests 3
  • a26445d: 8261404: Class.getReflectionFactory() is not thread-safe
  • 7b7fbdf: 8267938: (sctp) SCTP channel factory methods should check platform support
  • f3069d1: 8325972: Add -x to bash for building with LOG=debug
  • b425dff: 8320303: Allow PassFailJFrame to accept single window creator
  • bc14b9f: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop
  • 4ef8db8: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053
  • 6c0a88d: 8271142: package help is not displayed for missing X11/extensions/Xrandr.h
  • 2a78f2f: Merge
  • 5c5687d: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
  • ... and 14 more: https://git.openjdk.org/jdk11u-dev/compare/1bb3ed339b50b7cc60279bb51c36d8e449453d4e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 11, 2024
@openjdk openjdk bot closed this Mar 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 11, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@shipilev @amosshi Pushed as commit 9b40856.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8317287 branch March 13, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants