-
Notifications
You must be signed in to change notification settings - Fork 28
8226575: OperatingSystemMXBean should be made container aware #8
Conversation
👋 Welcome back kvergizova! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@kvergizova This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 50 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@kvergizova |
/sponsor |
@yan-too @kvergizova Since your change was applied there have been 50 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 89354b8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The patch applies cleanly, but it requires some modifications.
The original patch added new methods to OperatingSystemMXBean according to CSR JDK-8228428. Backporting them to 13u is not suitable.
Similar to 11u/8u, existing methods have been changed to return the container values instead.
CSR for 13u is filed: JDK-8255834, it's similar to 11u/8u CSR JDK-8248804.
Tested with tier1 and container tests on Linux and Windows, the only failure is containers/docker/TestMemoryAwareness.java which is fixed by follow-up JDK-8236617, the plan is to push them together.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/8/head:pull/8
$ git checkout pull/8