Navigation Menu

Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8256066: Tests use deprecated TestNG API that is no longer available in new versions #151

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Dec 9, 2021

Three tests fixed for newer TestNG. Works now with latest jtreg as well as jtreg 5.1


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8256066: Tests use deprecated TestNG API that is no longer available in new versions

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/151/head:pull/151
$ git checkout pull/151

Update a local copy of the PR:
$ git checkout pull/151
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/151/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 151

View PR using the GUI difftool:
$ git pr show -t 151

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/151.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 9, 2021

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6d8acd2696f41918d4233ddffe46e6c205f9dbc3 8256066: Tests use deprecated TestNG API that is no longer available in new versions Dec 9, 2021
@openjdk
Copy link

openjdk bot commented Dec 9, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 9, 2021

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8256066: Tests use deprecated TestNG API that is no longer available in new versions

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 9, 2021
@yan-too
Copy link
Collaborator Author

yan-too commented Dec 9, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Dec 9, 2021

Going to push as commit dd560a5.

@openjdk openjdk bot closed this Dec 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 9, 2021
@openjdk
Copy link

openjdk bot commented Dec 9, 2021

@yan-too Pushed as commit dd560a5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Dec 9, 2021

Webrevs

@yan-too yan-too deleted the b8256066 branch December 9, 2021 08:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant