Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293472: Incorrect container resource limit detection if manual cgroup fs mounts present #783

Closed

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Oct 12, 2022

Clean backport. Fixes some issues with logs showing up on some systems confusing tooling.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293472: Incorrect container resource limit detection if manual cgroup fs mounts present

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/783/head:pull/783
$ git checkout pull/783

Update a local copy of the PR:
$ git checkout pull/783
$ git pull https://git.openjdk.org/jdk17u-dev pull/783/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 783

View PR using the GUI difftool:
$ git pr show -t 783

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/783.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 12, 2022

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8f3bbe950fb5a3d9f6cae122209df01df0f342f0 8293472: Incorrect container resource limit detection if manual cgroup fs mounts present Oct 12, 2022
@openjdk
Copy link

openjdk bot commented Oct 12, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 12, 2022

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293472: Incorrect container resource limit detection if manual cgroup fs mounts present

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 12, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 12, 2022

Webrevs

@jerboaa
Copy link
Contributor Author

jerboaa commented Oct 14, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 14, 2022

Going to push as commit 14e4502.
Since your change was applied there have been 5 commits pushed to the master branch:

  • ac7d936: 8292158: AES-CTR cipher state corruption with AVX-512
  • c8d5f9a: 8282402: Create a regression test for JDK-4666101
  • 58b4363: 8251466: test/java/io/File/GetXSpace.java fails on Windows with mapped network drives.
  • 96a5e40: 8281296: Create a regression test for JDK-4515999
  • 4a49294: 8284681: compiler/c2/aarch64/TestFarJump.java fails with "RuntimeException: for CodeHeap < 250MB the far jump is expected to be encoded with a single branch instruction"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 14, 2022
@openjdk openjdk bot closed this Oct 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 14, 2022
@openjdk
Copy link

openjdk bot commented Oct 14, 2022

@jerboaa Pushed as commit 14e4502.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant