8273459: Update code segment alignment to 64 bytes #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back asgibbons! A progress list of the required criteria for merging this PR into |
openjdk
bot
changed the title
|
This backport pull request has now been updated with issue from the original commit. |
2 tasks
|
/integrate |
|
@asgibbons This pull request has not yet been marked as ready for integration. |
|
/sponsor |
|
@dwhite-intel The change author (@asgibbons) must issue an |
|
/integrate |
|
@asgibbons This pull request has not yet been marked as ready for integration. |
|
Created a clean PR #868 |
2 tasks
|
Closing this because of dependent PR issues. See #861 for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of 3 dependent backports for Base64 that are required to get the real bugfix cleanly integrated. The next one will be for align32(), then followed by the buffer overrun bugfix required for Base64 decoding to work properly.
Depends on PR #860 and #861 .
Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported.
Testing: x86_64 build, affected tests, tier1
Thanks,
--Scott
Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/862/head:pull/862$ git checkout pull/862Update a local copy of the PR:
$ git checkout pull/862$ git pull https://git.openjdk.org/jdk17u-dev pull/862/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 862View PR using the GUI difftool:
$ git pr show -t 862Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/862.diff