Skip to content

8273108: RunThese24H crashes with SEGV in markWord::displaced_mark_helper() after JDK-8268276 #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

asgibbons
Copy link
Contributor

@asgibbons asgibbons commented Nov 8, 2022

Last of 3 dependent backports for Base64 that are required to get the real bugfix cleanly integrated.

Depends on PR #860, #861, #862, and #863 .

Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported.

Testing: x86_64 build, affected tests, tier1

Thanks,
--Scott


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #863 must be integrated first

Issues

  • JDK-8273108: RunThese24H crashes with SEGV in markWord::displaced_mark_helper() after JDK-8268276
  • JDK-8272809: JFR thread sampler SI_KERNEL SEGV in metaspace::VirtualSpaceList::contains

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/864/head:pull/864
$ git checkout pull/864

Update a local copy of the PR:
$ git checkout pull/864
$ git pull https://git.openjdk.org/jdk17u-dev pull/864/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 864

View PR using the GUI difftool:
$ git pr show -t 864

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/864.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2022

👋 Welcome back asgibbons! A progress list of the required criteria for merging this PR into pr/863 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9a1bbaf8db0e869ab76be8ab1bd0ddeb23693e7e 8273108: RunThese24H crashes with SEGV in markWord::displaced_mark_helper() after JDK-8268276 Nov 8, 2022
@openjdk
Copy link

openjdk bot commented Nov 8, 2022

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Nov 8, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 8, 2022

Webrevs

@asgibbons
Copy link
Contributor Author

/integrate
Thanks, Goetz.

@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@asgibbons This pull request has not yet been marked as ready for integration.

@dwhite-intel
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@dwhite-intel The change author (@asgibbons) must issue an integrate command before the integration can be sponsored.

@asgibbons
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@asgibbons This pull request has not yet been marked as ready for integration.

@asgibbons
Copy link
Contributor Author

Created a clean PR #870

@asgibbons
Copy link
Contributor Author

Closing this because of dependent PR issues. See #861 for details.

@asgibbons asgibbons closed this Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants