Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277529: SIGSEGV in C2 CompilerThread Node::rematerialize() compiling Packet::readUnsignedTrint #322

Closed
wants to merge 1 commit into from

Conversation

fmatte1
Copy link
Contributor

@fmatte1 fmatte1 commented Dec 7, 2021

JDK-8277529
SIGSEGV in C2 CompilerThread Node::rematerialize() compiling Packet::readUnsignedTrint


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277529: SIGSEGV in C2 CompilerThread Node::rematerialize() compiling Packet::readUnsignedTrint

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/322/head:pull/322
$ git checkout pull/322

Update a local copy of the PR:
$ git checkout pull/322
$ git pull https://git.openjdk.java.net/jdk17u pull/322/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 322

View PR using the GUI difftool:
$ git pr show -t 322

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/322.diff

… Packet::readUnsignedTrint

Reviewed-by: chagedorn, vaibhav, fmatte, dholmes, thartmann
Backport-of: 01cb2b9883d7c9ecdba0ee5bd42124faed4d080c
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 7, 2021

👋 Welcome back fmatte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 01cb2b9883d7c9ecdba0ee5bd42124faed4d080c 8277529: SIGSEGV in C2 CompilerThread Node::rematerialize() compiling Packet::readUnsignedTrint Dec 7, 2021
@openjdk
Copy link

openjdk bot commented Dec 7, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 7, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 7, 2021

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good.

@openjdk
Copy link

openjdk bot commented Dec 7, 2021

@fmatte1 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277529: SIGSEGV in C2 CompilerThread Node::rematerialize() compiling Packet::readUnsignedTrint

Reviewed-by: thartmann, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 7, 2021
@fmatte1
Copy link
Contributor Author

fmatte1 commented Dec 7, 2021

Thanks, Tobias for the review.

Copy link
Member

@chhagedorn chhagedorn left a comment

Looks good!

@fmatte1
Copy link
Contributor Author

fmatte1 commented Dec 7, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 7, 2021
@openjdk
Copy link

openjdk bot commented Dec 7, 2021

@fmatte1
Your change (at version ce255f5) is now ready to be sponsored by a Committer.

@TobiHartmann
Copy link
Member

TobiHartmann commented Dec 7, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 7, 2021

Going to push as commit aa11a93.

@openjdk openjdk bot closed this Dec 7, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 7, 2021
@openjdk
Copy link

openjdk bot commented Dec 7, 2021

@TobiHartmann @fmatte1 Pushed as commit aa11a93.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants