Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313765: Invalid CEN header (invalid zip64 extra data field size) #376

Closed
wants to merge 1 commit into from

Conversation

benty-amzn
Copy link

@benty-amzn benty-amzn commented Aug 21, 2023

Backport of 8313765: Invalid CEN header (invalid zip64 extra data field size), jdk17u-dev #1670 for the 17.0.8.1 patch release.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313765: Invalid CEN header (invalid zip64 extra data field size) (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u.git pull/376/head:pull/376
$ git checkout pull/376

Update a local copy of the PR:
$ git checkout pull/376
$ git pull https://git.openjdk.org/jdk17u.git pull/376/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 376

View PR using the GUI difftool:
$ git pr show -t 376

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u/pull/376.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2023

👋 Welcome back btaylor! A progress list of the required criteria for merging this PR into jdk17.0.8.1 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 21, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 21, 2023

Webrevs

@benty-amzn benty-amzn changed the title 8313765: Invalid CEN header (invalid zip64 extra data field size) Backport 8313765: Invalid CEN header (invalid zip64 extra data field size) Aug 21, 2023
@openjdk openjdk bot removed the rfr Pull request is ready for review label Aug 21, 2023
Reviewed-by: andrew, serb
Backport-of: 13f6450e2e70df4df8bd882def837fbd5bef1524
@openjdk
Copy link

openjdk bot commented Aug 22, 2023

@benty-amzn this pull request can not be integrated into jdk17.0.8.1 due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8313765
git fetch https://git.openjdk.org/jdk17u.git jdk17.0.8.1
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge jdk17.0.8.1"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Aug 22, 2023
@openjdk
Copy link

openjdk bot commented Aug 22, 2023

@benty-amzn Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Aug 22, 2023
@benty-amzn benty-amzn changed the title Backport 8313765: Invalid CEN header (invalid zip64 extra data field size) Backport 13f6450e2e70df4df8bd882def837fbd5bef1524 Aug 22, 2023
@openjdk openjdk bot changed the title Backport 13f6450e2e70df4df8bd882def837fbd5bef1524 8313765: Invalid CEN header (invalid zip64 extra data field size) Aug 22, 2023
@openjdk
Copy link

openjdk bot commented Aug 22, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 22, 2023
Copy link
Member

@simonis simonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the downport!
Looks good to me.

@openjdk
Copy link

openjdk bot commented Aug 22, 2023

@benty-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313765: Invalid CEN header (invalid zip64 extra data field size)

Reviewed-by: simonis

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk17.0.8.1 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@simonis) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 22, 2023
@benty-amzn
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 22, 2023
@openjdk
Copy link

openjdk bot commented Aug 22, 2023

@benty-amzn
Your change (at version 75f0919) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Aug 23, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 23, 2023

Going to push as commit 0f29caa.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 23, 2023
@openjdk openjdk bot closed this Aug 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 23, 2023
@openjdk
Copy link

openjdk bot commented Aug 23, 2023

@GoeLin @benty-amzn Pushed as commit 0f29caa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants