-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8313765: Invalid CEN header (invalid zip64 extra data field size) #376
Conversation
👋 Welcome back btaylor! A progress list of the required criteria for merging this PR into |
Reviewed-by: andrew, serb Backport-of: 13f6450e2e70df4df8bd882def837fbd5bef1524
@benty-amzn this pull request can not be integrated into git checkout 8313765
git fetch https://git.openjdk.org/jdk17u.git jdk17.0.8.1
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge jdk17.0.8.1"
git push |
@benty-amzn Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the downport!
Looks good to me.
@benty-amzn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@simonis) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@benty-amzn |
/sponsor |
Going to push as commit 0f29caa. |
@GoeLin @benty-amzn Pushed as commit 0f29caa. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of 8313765: Invalid CEN header (invalid zip64 extra data field size), jdk17u-dev #1670 for the 17.0.8.1 patch release.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u.git pull/376/head:pull/376
$ git checkout pull/376
Update a local copy of the PR:
$ git checkout pull/376
$ git pull https://git.openjdk.org/jdk17u.git pull/376/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 376
View PR using the GUI difftool:
$ git pr show -t 376
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u/pull/376.diff
Webrev
Link to Webrev Comment