Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315971: ProblemList containers/docker/TestMemoryAwareness.java on linux-all #294

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Oct 26, 2023

Hi all,

This pull request contains a backport of commit eb37c7e3 from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 13 Sep 2023 and was reviewed by Aleksey Shipilev.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8315971 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8315971: ProblemList containers/docker/TestMemoryAwareness.java on linux-all (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/294/head:pull/294
$ git checkout pull/294

Update a local copy of the PR:
$ git checkout pull/294
$ git pull https://git.openjdk.org/jdk21u.git pull/294/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 294

View PR using the GUI difftool:
$ git pr show -t 294

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/294.diff

Webrev

Link to Webrev Comment

@mrserb mrserb marked this pull request as ready for review October 26, 2023 01:40
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 26, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport eb37c7e361527d937cf5d461a6cca54bd894e542 8315971: ProblemList containers/docker/TestMemoryAwareness.java on linux-all Oct 26, 2023
@openjdk
Copy link

openjdk bot commented Oct 26, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 26, 2023

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 26, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 26, 2023

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Oct 26, 2023

/approval request Clean backport. Problemlist is updated for the unstable test.

@openjdk
Copy link

openjdk bot commented Oct 26, 2023

@mrserb
8315971: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 26, 2023
@openjdk
Copy link

openjdk bot commented Oct 26, 2023

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315971: ProblemList containers/docker/TestMemoryAwareness.java on linux-all

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • c5a6a74: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 26, 2023
@mrserb
Copy link
Member Author

mrserb commented Oct 26, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 26, 2023

Going to push as commit 305e9ec.
Since your change was applied there has been 1 commit pushed to the master branch:

  • c5a6a74: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 26, 2023
@openjdk openjdk bot closed this Oct 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 26, 2023
@openjdk
Copy link

openjdk bot commented Oct 26, 2023

@mrserb Pushed as commit 305e9ec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant